chrome/browser/ui/omnibox/omnibox_current_page_delegate.h - Issue 21395002: [InstantExtended] Fixing how PageLoadSRP is emitted. Previously it was emitted only for Instant sea…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/omnibox/omnibox_current_page_delegate.h

Issue 21395002: [InstantExtended] Fixing how PageLoadSRP is emitted. Previously it was emitted only for Instant sea… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: last upload didn't seem to work Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/search_engines/template_url_service.cc ('K') | « chrome/browser/search_engines/template_url_service.cc ('k') | chrome/browser/ui/omnibox/omnibox_current_page_delegate_impl.h » ('j') | chrome/browser/ui/omnibox/omnibox_current_page_delegate_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/omnibox/omnibox_current_page_delegate.h

diff --git a/chrome/browser/ui/omnibox/omnibox_current_page_delegate.h b/chrome/browser/ui/omnibox/omnibox_current_page_delegate.h

index b21495b00fa6ab914108b27b54b66d0fd24a2aa4..e1713bfa2d010b09de771d523606695b1686d504 100644

--- a/chrome/browser/ui/omnibox/omnibox_current_page_delegate.h

+++ b/chrome/browser/ui/omnibox/omnibox_current_page_delegate.h

@@ -35,6 +35,9 @@ class OmniboxCurrentPageDelegate {

// Returns true if the visible entry is a New Tab Page rendered by Instant.

virtual bool IsInstantNTP() const = 0;

+ // Returns true if this is a search results page.

+ virtual bool IsSearchResultsPage() const = 0;

Peter Kasting 2013/07/31 23:56:51 Why do you need this? Nothing in the patch calls

rpetterson 2013/08/05 19:46:12 This is a partial merge from Mark's CL since the i

// Returns whether the current page is loading.

virtual bool IsLoading() const = 0;