[InstantExtended] Fixing how PageLoadSRP is emitted. Previously it was emitted only for Instant sea…

chrome/browser/ui/omnibox/omnibox_current_page_delegate_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/omnibox/omnibox_current_page_delegate_impl.h"
 
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/autocomplete/autocomplete_match.h"
 #include "chrome/browser/extensions/api/omnibox/omnibox_api.h"
 #include "chrome/browser/predictors/autocomplete_action_predictor.h"
 #include "chrome/browser/predictors/autocomplete_action_predictor_factory.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/search/search.h"
+#include "chrome/browser/search_engines/template_url_service.h"
+#include "chrome/browser/search_engines/template_url_service_factory.h"
 #include "chrome/browser/sessions/session_tab_helper.h"
 #include "chrome/browser/ui/omnibox/omnibox_edit_controller.h"
 #include "chrome/browser/ui/search/search_tab_helper.h"
 #include "content/public/browser/navigation_controller.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/browser/web_contents_view.h"
 #include "ui/base/window_open_disposition.h"
 #include "url/gurl.h"
 
 OmniboxCurrentPageDelegateImpl::OmniboxCurrentPageDelegateImpl(
     OmniboxEditController* controller,
     Profile* profile)
     : controller_(controller),
       profile_(profile) {}
 
 OmniboxCurrentPageDelegateImpl::~OmniboxCurrentPageDelegateImpl() {}
 
 bool OmniboxCurrentPageDelegateImpl::CurrentPageExists() const {
   return (controller_->GetWebContents() != NULL);
 }
 
 const GURL& OmniboxCurrentPageDelegateImpl::GetURL() const {
   return controller_->GetWebContents()->GetURL();
 }
 
 bool OmniboxCurrentPageDelegateImpl::IsInstantNTP() const {
   return chrome::IsInstantNTP(controller_->GetWebContents());
 }
 
+bool OmniboxCurrentPageDelegateImpl::IsSearchResultsPage() const {
+  content::WebContents* web_contents = controller_->GetWebContents();
+  Profile* profile =
+      Profile::FromBrowserContext(web_contents->GetBrowserContext());
+  return TemplateURLServiceFactory::GetForProfile(profile)->
+      IsSearchResultsPageFromDefaultSearchProvider(GetURL());

[Mark P, 2013/08/06 19:38:36]

optional nit: consider web_contents->GetURL()
(otherwise what's the point of making the alias on line 46, only to use it once,
on line 48?)

[Peter Kasting, 2013/08/06 21:32:19]

I'd probably resolve this by just inlining the first line into the second,
eliminating the temp.  I don't think avoiding using GetURL() here buys much.

[rpetterson, 2013/08/06 23:04:17]

I was trying to make it more readable. I've cleaned it up using Peter's approach
which reduced lines of code.

+}
+
 bool OmniboxCurrentPageDelegateImpl::IsLoading() const {
   return controller_->GetWebContents()->IsLoading();
 }
 
 content::NavigationController&
     OmniboxCurrentPageDelegateImpl::GetNavigationController() const {
   return controller_->GetWebContents()->GetController();
 }
 
 const SessionID& OmniboxCurrentPageDelegateImpl::GetSessionID() const {
@@ skipping 33 matching lines @@
     const AutocompleteMatch& match) {
   content::WebContents* web_contents = controller_->GetWebContents();
   gfx::Rect container_bounds;
   web_contents->GetView()->GetContainerBounds(&container_bounds);
   predictors::AutocompleteActionPredictorFactory::GetForProfile(profile_)->
       StartPrerendering(
           match.destination_url,
           web_contents->GetController().GetSessionStorageNamespaceMap(),
           container_bounds.size());
 }