Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Issue 2139483002: [Merge M53] [Autofill] Improve support for various credit card expiration dates. (Closed)

Created:
4 years, 5 months ago by Mathieu
Modified:
4 years, 5 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

[Merge M53] [Autofill] Improve support for various credit card expiration dates. Supports 2-digit years, and various combinations of mm/yyyy and single digit month combinations (e.g. m/yy). BUG=626537 TEST=CreditCardTest,PersonalDataManagerTest Review-Url: https://codereview.chromium.org/2136453003 Cr-Commit-Position: refs/heads/master@{#404467} (cherry picked from commit 303f4384d13900b31a5b854843b2a18d36176639) Committed: https://chromium.googlesource.com/chromium/src/+/915707859844eade749a2f732f9f3382adcf2918

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+316 lines, -132 lines) Patch
M components/autofill/core/browser/credit_card.h View 3 chunks +11 lines, -1 line 0 comments Download
M components/autofill/core/browser/credit_card.cc View 12 chunks +72 lines, -14 lines 0 comments Download
M components/autofill/core/browser/credit_card_unittest.cc View 3 chunks +75 lines, -2 lines 0 comments Download
M components/autofill/core/browser/personal_data_manager_unittest.cc View 41 chunks +158 lines, -57 lines 0 comments Download
M components/autofill/core/browser/validation.h View 1 chunk +0 lines, -3 lines 0 comments Download
M components/autofill/core/browser/validation.cc View 1 chunk +0 lines, -20 lines 0 comments Download
M components/autofill/core/browser/validation_unittest.cc View 2 chunks +0 lines, -35 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Mathieu
4 years, 5 months ago (2016-07-09 19:05:12 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
915707859844eade749a2f732f9f3382adcf2918.

Powered by Google App Engine
This is Rietveld 408576698