Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Unified Diff: scripts/slave/recipes/run_presubmit.expected/depot_tools_and_gerrit.json

Issue 2139413002: Add depot_tools Gerrit presubmit expectations. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « scripts/slave/recipes/run_presubmit.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipes/run_presubmit.expected/depot_tools_and_gerrit.json
diff --git a/scripts/slave/recipes/run_presubmit.expected/depot_tools.json b/scripts/slave/recipes/run_presubmit.expected/depot_tools_and_gerrit.json
similarity index 84%
copy from scripts/slave/recipes/run_presubmit.expected/depot_tools.json
copy to scripts/slave/recipes/run_presubmit.expected/depot_tools_and_gerrit.json
index 8cc6dec44b94fa72404740b327a2f45be5f0c1e5..8e5defb558fbf6a3bf1a00684a4c3a2d337d2529 100644
--- a/scripts/slave/recipes/run_presubmit.expected/depot_tools.json
+++ b/scripts/slave/recipes/run_presubmit.expected/depot_tools_and_gerrit.json
@@ -5,9 +5,9 @@
"-u",
"RECIPE_MODULE[depot_tools::bot_update]/resources/bot_update.py",
"--master",
- "tryserver.chromium.linux",
+ "tryserver.infra",
"--builder",
- "depot_tools_presubmit",
+ "presubmit_depot_tools",
"--slave",
"TestSlavename",
"--spec",
@@ -18,12 +18,10 @@
"{\"depot_tools\": \"got_revision\"}",
"--git-cache-dir",
"[GIT_CACHE]",
- "--issue",
- "12853011",
- "--patchset",
- "1",
- "--rietveld_server",
- "https://codereview.chromium.org",
+ "--gerrit_repo",
+ "https://chromium.googlesource.com/chromium/tools/depot_tools",
+ "--gerrit_ref",
+ "refs/changes/11/338811/3",
"--output_json",
"/path/to/tmp/json",
"--revision",
@@ -80,16 +78,27 @@
"cmd": [
"python",
"-u",
+ "RECIPE_PACKAGE_REPO[depot_tools]/gclient.py",
+ "runhooks"
+ ],
+ "cwd": "[SLAVE_BUILD]/depot_tools",
+ "env": {
+ "PATH": "%(PATH)s:RECIPE_PACKAGE_REPO[depot_tools]"
+ },
+ "name": "gclient runhooks"
+ },
+ {
+ "cmd": [
+ "python",
+ "-u",
"RECIPE_PACKAGE_REPO[depot_tools]/presubmit_support.py",
"--issue",
- "12853011",
+ "338811",
"--patchset",
- "1",
- "--rietveld_url",
- "https://codereview.chromium.org",
- "--rietveld_fetch",
- "--rietveld_email",
- "",
+ "3",
+ "--gerrit_url",
+ "https://chromium-review.googlesource.com",
+ "--gerrit_fetch",
"--root",
"[SLAVE_BUILD]/depot_tools",
"--commit",
« no previous file with comments | « scripts/slave/recipes/run_presubmit.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698