Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 2139393002: Revert of Remove constructor from remaining functions that aren't constructors (Closed)

Created:
4 years, 5 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 4 months ago
Reviewers:
haraken, pfeldman
CC:
apavlov+blink_chromium.org, blink-reviews, blink-reviews-bindings_chromium.org, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, sergeyv+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove constructor from remaining functions that aren't constructors (patchset #1 id:1 of https://codereview.chromium.org/2124183003/ ) Reason for revert: Reverting while investigating blob_storage failures Original issue's description: > Remove constructor from remaining functions that aren't constructors > > BUG=625823 > R=haraken@chromium.org,pfeldman@chromium.org > > Committed: https://crrev.com/587b0b37724cdfc0eec5ed091b94eb8276bc05ce > Cr-Commit-Position: refs/heads/master@{#404137} TBR=haraken@chromium.org,pfeldman@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=625823

Patch Set 1 #

Messages

Total messages: 7 (2 generated)
jochen (gone - plz use gerrit)
Created Revert of Remove constructor from remaining functions that aren't constructors
4 years, 5 months ago (2016-07-12 17:50:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2139393002/1
4 years, 5 months ago (2016-07-12 17:51:53 UTC) #3
haraken
LGTM
4 years, 5 months ago (2016-07-13 00:00:28 UTC) #5
xdai1
This CL needs to merge into M53(branch head: 2785). Otherwise the M53 build fails at ...
4 years, 4 months ago (2016-08-17 22:18:58 UTC) #6
xdai1
4 years, 4 months ago (2016-08-18 00:35:25 UTC) #7
Message was sent while issue was closed.
On 2016/08/17 22:18:58, xdai1 wrote:
> This CL needs to merge into M53(branch head: 2785). Otherwise the M53 build
> fails at compile time.

Filed the bug crbug.com/638789

Powered by Google App Engine
This is Rietveld 408576698