Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorSession.h

Issue 2139363003: [DevTools] Cleanup v8_inspector API part 1. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebased Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorSession.h
diff --git a/third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorSession.h b/third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorSession.h
index 6264b97b629925ddbb2236a23679a8c07f9aeb88..2103467e44087b4068d9038782bd39b21dae061a 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorSession.h
+++ b/third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorSession.h
@@ -12,15 +12,9 @@
namespace blink {
-class V8DebuggerAgent;
-class V8HeapProfilerAgent;
-class V8InspectorSessionClient;
-class V8ProfilerAgent;
-class V8RuntimeAgent;
-
class PLATFORM_EXPORT V8InspectorSession {
public:
- static const char backtraceObjectGroup[];
+ virtual ~V8InspectorSession() { }
// Cross-context inspectable values (DOM nodes in different worlds, etc.).
class Inspectable {
@@ -28,15 +22,15 @@ public:
virtual v8::Local<v8::Value> get(v8::Local<v8::Context>) = 0;
virtual ~Inspectable() { }
};
+ virtual void addInspectedObject(std::unique_ptr<Inspectable>) = 0;
- virtual ~V8InspectorSession() { }
-
+ // Dispatching protocol messages.
+ // TODO(dgozman): generate this one.
static bool isV8ProtocolMethod(const String16& method);
virtual void dispatchProtocolMessage(const String16& message) = 0;
virtual String16 stateJSON() = 0;
- virtual void addInspectedObject(std::unique_ptr<Inspectable>) = 0;
- // API for the embedder to report native activities.
+ // Debugger actions.
virtual void schedulePauseOnNextStatement(const String16& breakReason, std::unique_ptr<protocol::DictionaryValue> data) = 0;
virtual void cancelPauseOnNextStatement() = 0;
virtual void breakProgram(const String16& breakReason, std::unique_ptr<protocol::DictionaryValue> data) = 0;
@@ -44,10 +38,9 @@ public:
virtual void resume() = 0;
virtual void stepOver() = 0;
- // API to work with remote objects.
- virtual std::unique_ptr<protocol::Runtime::RemoteObject> wrapObject(v8::Local<v8::Context>, v8::Local<v8::Value>, const String16& groupName, bool generatePreview = false) = 0;
- // FIXME: remove when InspectorConsoleAgent moves into V8 inspector.
- virtual std::unique_ptr<protocol::Runtime::RemoteObject> wrapTable(v8::Local<v8::Context>, v8::Local<v8::Value> table, v8::Local<v8::Value> columns) = 0;
+ // Remote objects.
+ static const char backtraceObjectGroup[];
+ virtual std::unique_ptr<protocol::Runtime::RemoteObject> wrapObject(v8::Local<v8::Context>, v8::Local<v8::Value>, const String16& groupName, bool generatePreview) = 0;
virtual v8::Local<v8::Value> findObject(ErrorString*, const String16& objectId, v8::Local<v8::Context>* = nullptr, String16* objectGroup = nullptr) = 0;
virtual void releaseObjectGroup(const String16&) = 0;
};

Powered by Google App Engine
This is Rietveld 408576698