Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1029)

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.h

Issue 2139363003: [DevTools] Cleanup v8_inspector API part 1. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebased Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.h
diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.h b/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.h
index d68d2a1508cfd2e4cc68bd0072e5e5827312f5f9..d6ada6151aafabce69a833ea4419f5be685c6f37 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.h
+++ b/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.h
@@ -23,13 +23,15 @@ class V8StackTrace;
enum class V8MessageOrigin { kConsole, kException, kRevokedException };
+enum class ConsoleAPIType { kLog, kDir, kDirXML, kTable, kTrace, kStartGroup, kStartGroupCollapsed, kEndGroup, kClear, kAssert, kTimeEnd, kCount };
+
class V8ConsoleMessage {
public:
~V8ConsoleMessage();
static std::unique_ptr<V8ConsoleMessage> createForConsoleAPI(
double timestamp,
- MessageType,
+ ConsoleAPIType,
MessageLevel,
const String16& message,
std::vector<v8::Local<v8::Value>>* arguments,
@@ -71,7 +73,7 @@ public:
void reportToFrontend(protocol::Console::Frontend*, V8InspectorSessionImpl*, bool generatePreview) const;
void reportToFrontend(protocol::Runtime::Frontend*, V8InspectorSessionImpl*, bool generatePreview) const;
unsigned argumentCount() const;
- MessageType type() const;
+ ConsoleAPIType type() const;
void contextDestroyed(int contextId);
private:
@@ -95,7 +97,7 @@ private:
String16 m_requestIdentifier;
String16 m_workerId;
int m_contextId;
- MessageType m_type;
+ ConsoleAPIType m_type;
unsigned m_exceptionId;
unsigned m_revokedExceptionId;
Arguments m_arguments;

Powered by Google App Engine
This is Rietveld 408576698