third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp - Issue 2139363003: [DevTools] Cleanup v8_inspector API part 1.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp

Issue 2139363003: [DevTools] Cleanup v8_inspector API part 1. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebased Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp

diff --git a/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp b/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp

index f42cdb6a1be22d8fe284c48d2b7e61ad6b155f7a..c985e9daefb20fb6ff4821ab8520003a7dcd91f4 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp

+++ b/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp

@@ -399,7 +399,7 @@ void InjectedScript::Scope::ignoreExceptionsAndMuteConsole()

{

DCHECK(!m_ignoreExceptionsAndMuteConsole);

m_ignoreExceptionsAndMuteConsole = true;

- m_debugger->muteConsole();

+ m_debugger->client()->muteWarningsAndDeprecations();

m_previousPauseOnExceptionsState = setPauseOnExceptionsState(V8DebuggerImpl::DontPauseOnExceptions);

}

@@ -433,7 +433,7 @@ InjectedScript::Scope::~Scope()

{

if (m_ignoreExceptionsAndMuteConsole) {

setPauseOnExceptionsState(m_previousPauseOnExceptionsState);

- m_debugger->unmuteConsole();

+ m_debugger->client()->unmuteWarningsAndDeprecations();

}

if (m_userGesture)

m_debugger->client()->endUserGesture();