Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Unified Diff: third_party/WebKit/Source/core/frame/FrameConsole.cpp

Issue 2139363003: [DevTools] Cleanup v8_inspector API part 1. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebased Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/frame/FrameConsole.cpp
diff --git a/third_party/WebKit/Source/core/frame/FrameConsole.cpp b/third_party/WebKit/Source/core/frame/FrameConsole.cpp
index a27fb0c88399ad7433c0e32a4ca9ddca3074d9e1..ad42cc6981e17df4d26ce5ebc73f67adda6c73c8 100644
--- a/third_party/WebKit/Source/core/frame/FrameConsole.cpp
+++ b/third_party/WebKit/Source/core/frame/FrameConsole.cpp
@@ -31,7 +31,6 @@
#include "bindings/core/v8/SourceLocation.h"
#include "core/frame/FrameHost.h"
#include "core/inspector/ConsoleMessage.h"
-#include "core/inspector/IdentifiersFactory.h"
#include "core/inspector/MainThreadDebugger.h"
#include "core/page/ChromeClient.h"
#include "core/page/Page.h"
@@ -58,19 +57,7 @@ bool FrameConsole::addMessageToStorage(ConsoleMessage* consoleMessage)
// TODO(dgozman): drop this check, it's left here to preserve tests output.
if (!m_frame->document())
return false;
- MainThreadDebugger* debugger = MainThreadDebugger::instance();
- return debugger->debugger()->addConsoleMessage(
- debugger->contextGroupId(m_frame),
- consoleMessage->source(),
- consoleMessage->level(),
- consoleMessage->message(),
- consoleMessage->location()->url(),
- consoleMessage->location()->lineNumber(),
- consoleMessage->location()->columnNumber(),
- consoleMessage->location()->cloneStackTrace(),
- consoleMessage->location()->scriptId(),
- IdentifiersFactory::requestId(consoleMessage->requestIdentifier()),
- consoleMessage->workerId());
+ return MainThreadDebugger::instance()->addConsoleMessage(m_frame, consoleMessage);
}
void FrameConsole::reportMessageToClient(ConsoleMessage* consoleMessage)
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698