Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 2139333002: remove unused parameter to make android happy (when this header is moved to private) (Closed)

Created:
4 years, 5 months ago by reed1
Modified:
4 years, 5 months ago
Reviewers:
msarett, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

remove unused parameter to make android happy (when this header is moved to private) BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2139333002 Committed: https://skia.googlesource.com/skia/+/1264472c06cebd283d1ec123014c58f5d3c4cad1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/core/SkNx.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 14 (8 generated)
reed1
4 years, 5 months ago (2016-07-12 15:22:45 UTC) #3
mtklein
lgtm
4 years, 5 months ago (2016-07-12 15:25:54 UTC) #6
mtklein
If if becomes a problem, I don't mind removing the assert.
4 years, 5 months ago (2016-07-12 15:26:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2139333002/1
4 years, 5 months ago (2016-07-12 15:50:06 UTC) #11
reed1
I find android's warning/error much more annoying. I like the assert.
4 years, 5 months ago (2016-07-12 15:50:29 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-12 16:12:37 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/1264472c06cebd283d1ec123014c58f5d3c4cad1

Powered by Google App Engine
This is Rietveld 408576698