Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Unified Diff: chrome/browser/ui/webui/print_preview/sticky_settings.cc

Issue 2139303003: Modified printing to no longer store its own save path. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixed comments, spacing Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/print_preview/sticky_settings.cc
diff --git a/chrome/browser/ui/webui/print_preview/sticky_settings.cc b/chrome/browser/ui/webui/print_preview/sticky_settings.cc
index adc121b3c4807bb77216fa3964fef4a5bcb6eede..d88db3e98fdee58424bb3bb9f305ef5447ffca5c 100644
--- a/chrome/browser/ui/webui/print_preview/sticky_settings.cc
+++ b/chrome/browser/ui/webui/print_preview/sticky_settings.cc
@@ -16,7 +16,6 @@
namespace printing {
-const char kSettingSavePath[] = "savePath";
const char kSettingAppState[] = "appState";
StickySettings::StickySettings() {}
@@ -27,16 +26,10 @@ void StickySettings::StoreAppState(const std::string& data) {
printer_app_state_.reset(new std::string(data));
}
-void StickySettings::StoreSavePath(const base::FilePath& path) {
- save_path_.reset(new base::FilePath(path));
-}
-
void StickySettings::SaveInPrefs(PrefService* prefs) {
DCHECK(prefs);
if (prefs) {
std::unique_ptr<base::DictionaryValue> value(new base::DictionaryValue);
- if (save_path_.get())
- value->SetString(printing::kSettingSavePath, save_path_->value());
if (printer_app_state_.get())
value->SetString(printing::kSettingAppState,
*printer_app_state_);
@@ -51,8 +44,6 @@ void StickySettings::RestoreFromPrefs(PrefService* prefs) {
prefs->GetDictionary(prefs::kPrintPreviewStickySettings);
base::FilePath::StringType save_path;
Lei Zhang 2016/07/13 22:16:09 This is no longer used. It's weird how the compile
- if (value->GetString(printing::kSettingSavePath, &save_path))
- save_path_.reset(new base::FilePath(save_path));
std::string buffer;
if (value->GetString(printing::kSettingAppState, &buffer))
printer_app_state_.reset(new std::string(buffer));
@@ -68,8 +59,4 @@ std::string* StickySettings::printer_app_state() {
return printer_app_state_.get();
}
-base::FilePath* StickySettings::save_path() {
- return save_path_.get();
-}
-
} // namespace printing

Powered by Google App Engine
This is Rietveld 408576698