Modified printing to no longer store its own save path.

Modified printing to no longer store its own save path.

Instead, uses the save path from Download preferences.

This initializes to the path set by the user in Settings, then
updates with each Download or Save to PDF.

BUG=136331
Committed: https://crrev.com/0e727b342a141b380424c504d364e3a0e66c91f4
Cr-Commit-Position: refs/heads/master@{#405515}

[rbpotter, 2016-07-12 23:59:57]

Description was changed from

==========
Modified printing to no longer store its own save path.

Instead, uses the save path from Download preferences.

This initializes to the path set by the user in Settings, then
updates with each Download or Save to PDF.

BUG=136331
==========

to

==========
Modified printing to no longer store its own save path.

Instead, uses the save path from Download preferences.

This initializes to the path set by the user in Settings, then
updates with each Download or Save to PDF.

BUG=136331
==========

[rbpotter, 2016-07-12 23:59:57]

rbpotter@chromium.org changed reviewers:
+ thestig@chromium.org

[Lei Zhang, 2016-07-13 21:57:36]

thestig@chromium.org changed reviewers:
+ asanka@chromium.org

[Lei Zhang, 2016-07-13 21:57:37]

+asanka since this involves downloads.

[Lei Zhang, 2016-07-13 22:16:09]

https://codereview.chromium.org/2139303003/diff/20001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/print_preview/print_preview_handler.cc (right):

https://codereview.chromium.org/2139303003/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/print_preview/print_preview_handler.cc:1362:
printing::StickySettings* sticky_settings = GetStickySettings();
Move this down to line 1365, so it is closer to where it's used, or just don't
bother with the pointer and just call GetStickySettings()-Foo(), now that we
only use it in a single place.

Ditto in PrintPreviewHandler::FileSelected() below.

https://codereview.chromium.org/2139303003/diff/20001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/print_preview/sticky_settings.cc (right):

https://codereview.chromium.org/2139303003/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/print_preview/sticky_settings.cc:46:
base::FilePath::StringType save_path;
This is no longer used. It's weird how the compiler doesn't catch this.

https://codereview.chromium.org/2139303003/diff/20001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/print_preview/sticky_settings.h (right):

https://codereview.chromium.org/2139303003/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/print_preview/sticky_settings.h:17: class FilePath;
No longer needed.

[Lei Zhang, 2016-07-13 22:20:52]

https://codereview.chromium.org/2139303003/diff/20001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/print_preview/print_preview_handler.cc (left):

https://codereview.chromium.org/2139303003/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/print_preview/print_preview_handler.cc:1366:
base::ThreadRestrictions::ScopedAllowIO allow_io;
The #includes for base/path_service.h, base/threading/thread_restrictions.h and
chrome/common/chrome_paths.h are also no longer needed.

https://codereview.chromium.org/2139303003/diff/20001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/print_preview/sticky_settings.cc (right):

https://codereview.chromium.org/2139303003/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/print_preview/sticky_settings.cc:8: #include
"base/files/file_path.h"
Also no longer needed.

[rbpotter, 2016-07-14 01:15:51]

The CQ bit was checked by rbpotter@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-14 01:16:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rbpotter, 2016-07-14 01:16:50]

The CQ bit was checked by rbpotter@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-14 01:17:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-14 02:35:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-14 02:35:51]

Dry run: This issue passed the CQ dry run.

[Lei Zhang, 2016-07-14 09:43:08]

lgtm, but please wait for asanka@ to chime in.

Also, please send email, otherwise this can easily get ignored.

https://codereview.chromium.org/2139303003/diff/40001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/print_preview/print_preview_handler.cc (right):

https://codereview.chromium.org/2139303003/diff/40001/chrome/browser/ui/webui...
chrome/browser/ui/webui/print_preview/print_preview_handler.cc:1421:
sticky_settings->SaveInPrefs(Profile::FromBrowserContext(
indentation is off

[asanka, 2016-07-14 16:37:39]

lgtm. Thanks for checking with us.

[rbpotter, 2016-07-14 17:39:15]

The CQ bit was checked by rbpotter@chromium.org

[commit-bot: I haz the power, 2016-07-14 17:39:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-14 17:44:31]

Description was changed from

==========
Modified printing to no longer store its own save path.

Instead, uses the save path from Download preferences.

This initializes to the path set by the user in Settings, then
updates with each Download or Save to PDF.

BUG=136331
==========

to

==========
Modified printing to no longer store its own save path.

Instead, uses the save path from Download preferences.

This initializes to the path set by the user in Settings, then
updates with each Download or Save to PDF.

BUG=136331
==========

[commit-bot: I haz the power, 2016-07-14 17:44:32]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-14 17:44:34]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-14 17:47:24]

Description was changed from

==========
Modified printing to no longer store its own save path.

Instead, uses the save path from Download preferences.

This initializes to the path set by the user in Settings, then
updates with each Download or Save to PDF.

BUG=136331
==========

to

==========
Modified printing to no longer store its own save path.

Instead, uses the save path from Download preferences.

This initializes to the path set by the user in Settings, then
updates with each Download or Save to PDF.

BUG=136331

Committed: https://crrev.com/0e727b342a141b380424c504d364e3a0e66c91f4
Cr-Commit-Position: refs/heads/master@{#405515}
==========

[commit-bot: I haz the power, 2016-07-14 17:47:25]

Patchset 3 (id:??) landed as
https://crrev.com/0e727b342a141b380424c504d364e3a0e66c91f4
Cr-Commit-Position: refs/heads/master@{#405515}