Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Side by Side Diff: content/renderer/render_frame_impl.cc

Issue 2139303002: Clean up around methods to enter/exit fullscreen (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/renderer/render_frame_impl.h ('k') | content/renderer/render_frame_proxy.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/renderer/render_frame_impl.h" 5 #include "content/renderer/render_frame_impl.h"
6 6
7 #include <map> 7 #include <map>
8 #include <string> 8 #include <string>
9 #include <utility> 9 #include <utility>
10 #include <vector> 10 #include <vector>
(...skipping 4410 matching lines...) Expand 10 before | Expand all | Expand 10 after
4421 render_accessibility_->HandleAccessibilityFindInPageResult( 4421 render_accessibility_->HandleAccessibilityFindInPageResult(
4422 identifier, match_index, start_object, start_offset, 4422 identifier, match_index, start_object, start_offset,
4423 end_object, end_offset); 4423 end_object, end_offset);
4424 } 4424 }
4425 } 4425 }
4426 4426
4427 void RenderFrameImpl::didChangeManifest() { 4427 void RenderFrameImpl::didChangeManifest() {
4428 FOR_EACH_OBSERVER(RenderFrameObserver, observers_, DidChangeManifest()); 4428 FOR_EACH_OBSERVER(RenderFrameObserver, observers_, DidChangeManifest());
4429 } 4429 }
4430 4430
4431 bool RenderFrameImpl::enterFullscreen() { 4431 void RenderFrameImpl::enterFullscreen() {
4432 Send(new FrameHostMsg_ToggleFullscreen(routing_id_, true)); 4432 Send(new FrameHostMsg_ToggleFullscreen(routing_id_, true));
4433 return true;
4434 } 4433 }
4435 4434
4436 bool RenderFrameImpl::exitFullscreen() { 4435 void RenderFrameImpl::exitFullscreen() {
4437 Send(new FrameHostMsg_ToggleFullscreen(routing_id_, false)); 4436 Send(new FrameHostMsg_ToggleFullscreen(routing_id_, false));
4438 return true;
4439 } 4437 }
4440 4438
4441 blink::WebPermissionClient* RenderFrameImpl::permissionClient() { 4439 blink::WebPermissionClient* RenderFrameImpl::permissionClient() {
4442 if (!permission_client_) { 4440 if (!permission_client_) {
4443 permission_client_.reset( 4441 permission_client_.reset(
4444 new PermissionDispatcher(GetRemoteInterfaces())); 4442 new PermissionDispatcher(GetRemoteInterfaces()));
4445 } 4443 }
4446 return permission_client_.get(); 4444 return permission_client_.get();
4447 } 4445 }
4448 4446
(...skipping 1879 matching lines...) Expand 10 before | Expand all | Expand 10 after
6328 // event target. Potentially a Pepper plugin will receive the event. 6326 // event target. Potentially a Pepper plugin will receive the event.
6329 // In order to tell whether a plugin gets the last mouse event and which it 6327 // In order to tell whether a plugin gets the last mouse event and which it
6330 // is, we set |pepper_last_mouse_event_target_| to null here. If a plugin gets 6328 // is, we set |pepper_last_mouse_event_target_| to null here. If a plugin gets
6331 // the event, it will notify us via DidReceiveMouseEvent() and set itself as 6329 // the event, it will notify us via DidReceiveMouseEvent() and set itself as
6332 // |pepper_last_mouse_event_target_|. 6330 // |pepper_last_mouse_event_target_|.
6333 pepper_last_mouse_event_target_ = nullptr; 6331 pepper_last_mouse_event_target_ = nullptr;
6334 #endif 6332 #endif
6335 } 6333 }
6336 6334
6337 } // namespace content 6335 } // namespace content
OLDNEW
« no previous file with comments | « content/renderer/render_frame_impl.h ('k') | content/renderer/render_frame_proxy.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698