Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2139293004: [TEMP - DO NOT SUBMIT] OfflinePagesProvider (Closed)

Created:
4 years, 5 months ago by Philipp Keck
Modified:
4 years, 5 months ago
Reviewers:
CC:
chromium-reviews, ntp-dev+reviews_chromium.org, droger+watchlist_chromium.org, romax+watch_chromium.org, blundell+watchlist_chromium.org, dewittj+watch_chromium.org, sdefresne+watchlist_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, rginda+watch_chromium.org, arv+watch_chromium.org, asvitkine+watch_chromium.org, fgorski+watch_chromium.org, dimich+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@internalspage
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[TEMP - DO NOT SUBMIT] OfflinePagesProvider BUG= CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Patch Set 1 #

Patch Set 2 : Implement OfflinePage conversion #

Unified diffs Side-by-side diffs Delta from patch set Stats (+399 lines, -12 lines) Patch
M chrome/app/generated_resources.grd View 1 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/android/chrome_feature_list.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/android/chrome_feature_list.cc View 2 chunks +4 lines, -0 lines 0 comments Download
A + chrome/browser/ntp_snippets/offline_page_suggestions_provider_factory.h View 2 chunks +12 lines, -10 lines 0 comments Download
A chrome/browser/ntp_snippets/offline_page_suggestions_provider_factory.cc View 1 chunk +82 lines, -0 lines 0 comments Download
M chrome/browser/profiles/profile_manager.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/snippets_internals.html View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/snippets_internals_message_handler.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M components/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/ntp_snippets.gypi View 1 chunk +19 lines, -0 lines 0 comments Download
M components/ntp_snippets/content_suggestions_category.h View 1 chunk +6 lines, -1 line 0 comments Download
A components/ntp_snippets/offline_pages/BUILD.gn View 1 chunk +37 lines, -0 lines 0 comments Download
A components/ntp_snippets/offline_pages/DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
A components/ntp_snippets/offline_pages/offline_page_suggestions_provider.h View 1 chunk +80 lines, -0 lines 0 comments Download
A components/ntp_snippets/offline_pages/offline_page_suggestions_provider.cc View 1 1 chunk +127 lines, -0 lines 0 comments Download
M components/offline_pages/background/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Issue 2145563002 Patch 120001

Messages

Total messages: 2 (1 generated)
Philipp Keck
4 years, 5 months ago (2016-07-14 11:39:37 UTC) #2
Message was sent while issue was closed. 
On 2016/07/13 11:00:36, Philipp Keck wrote:
> Description was changed from
> 
> ==========
> [TEMP - DO NOT SUBMIT] OfflinePagesProvider
> 
> BUG=
> ==========
> 
> to
> 
> ==========
> [TEMP - DO NOT SUBMIT] OfflinePagesProvider
> 
> BUG=
> CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
> ==========

These changes are now here: https://codereview.chromium.org/2149453004

Powered by Google App Engine
This is Rietveld 408576698