chrome/browser/page_load_metrics/page_load_metrics_initialize.cc - Issue 2139243003: customtabs: Send time to first contentful paint to the caller.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/page_load_metrics_initialize.cc

Issue 2139243003: customtabs: Send time to first contentful paint to the caller. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/page_load_metrics/observers/android_page_load_metrics_observer.cc ('K') | « chrome/browser/page_load_metrics/observers/android_page_load_metrics_observer.cc ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/page_load_metrics_initialize.cc

diff --git a/chrome/browser/page_load_metrics/page_load_metrics_initialize.cc b/chrome/browser/page_load_metrics/page_load_metrics_initialize.cc

index 609afa06e4f36f59235fc46c3c7f5187e2d66493..3ba344e7f3399312ea5d0a4c64060c9c217a11b1 100644

--- a/chrome/browser/page_load_metrics/page_load_metrics_initialize.cc

+++ b/chrome/browser/page_load_metrics/page_load_metrics_initialize.cc

@@ -6,6 +6,9 @@

#include "base/macros.h"

#include "base/memory/ptr_util.h"

+#if defined(OS_ANDROID)

+#include "chrome/browser/page_load_metrics/observers/android_page_load_metrics_observer.h"

+#endif // OS_ANDROID

#include "chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.h"

#include "chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h"

#include "chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.h"

@@ -70,6 +73,10 @@ void PageLoadMetricsEmbedder::RegisterObservers(

tracker->AddObserver(

base::WrapUnique(new HttpsEngagementPageLoadMetricsObserver(

web_contents_->GetBrowserContext())));

+#if defined(OS_ANDROID)

+ tracker->AddObserver(

+ base::WrapUnique(new AndroidPageLoadMetricsObserver(web_contents_)));

+#endif // OS_ANDROID

}

bool PageLoadMetricsEmbedder::IsPrerendering(