components/page_load_metrics/browser/metrics_web_contents_observer.h - Issue 2139243003: customtabs: Send time to first contentful paint to the caller.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/page_load_metrics/browser/metrics_web_contents_observer.h

Issue 2139243003: customtabs: Send time to first contentful paint to the caller. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/page_load_metrics/observers/android_page_load_metrics_observer.h ('K') | « chrome/chrome_browser.gypi ('k') | components/page_load_metrics/browser/metrics_web_contents_observer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/page_load_metrics/browser/metrics_web_contents_observer.h

diff --git a/components/page_load_metrics/browser/metrics_web_contents_observer.h b/components/page_load_metrics/browser/metrics_web_contents_observer.h

index d9e06e865eca3d776939d9d019216c5e96a31b33..afe26097d08c9379bab04c3954f8203c33cccec8 100644

--- a/components/page_load_metrics/browser/metrics_web_contents_observer.h

+++ b/components/page_load_metrics/browser/metrics_web_contents_observer.h

@@ -108,7 +108,8 @@ class PageLoadMetricsEmbedderInterface {

virtual ~PageLoadMetricsEmbedderInterface() {}

virtual bool IsPrerendering(content::WebContents* web_contents) = 0;

virtual bool IsNewTabPageUrl(const GURL& url) = 0;

- virtual void RegisterObservers(PageLoadTracker* metrics) = 0;

+ virtual void RegisterObservers(PageLoadTracker* metrics,

+ content::WebContents* web_contents) = 0;

Bryan McQuade 2016/07/21 23:56:13 the PageLoadMetricsEmbedder implementation now has

Benoit L 2016/07/22 15:41:31 Ah, thanks! Done.

};

// This class tracks a given page load, starting from navigation start /