components/page_load_metrics/browser/metrics_web_contents_observer.cc - Issue 2139243003: customtabs: Send time to first contentful paint to the caller.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/page_load_metrics/browser/metrics_web_contents_observer.cc

Issue 2139243003: customtabs: Send time to first contentful paint to the caller. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/page_load_metrics/browser/metrics_web_contents_observer.h ('K') | « components/page_load_metrics/browser/metrics_web_contents_observer.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/page_load_metrics/browser/metrics_web_contents_observer.cc

diff --git a/components/page_load_metrics/browser/metrics_web_contents_observer.cc b/components/page_load_metrics/browser/metrics_web_contents_observer.cc

index 5009703a5e7ab0b092cd7ceaa59e0657cd4547b3..553b2af327f63277da9af4af87cfba491d134a67 100644

--- a/components/page_load_metrics/browser/metrics_web_contents_observer.cc

+++ b/components/page_load_metrics/browser/metrics_web_contents_observer.cc

@@ -265,7 +265,8 @@ PageLoadTracker::PageLoadTracker(

aborted_chain_size_same_url_(aborted_chain_size_same_url),

embedder_interface_(embedder_interface) {

DCHECK(!navigation_handle->HasCommitted());

- embedder_interface_->RegisterObservers(this);

+ embedder_interface_->RegisterObservers(this,

+ navigation_handle->GetWebContents());

for (const auto& observer : observers_) {

observer->OnStart(navigation_handle, currently_committed_url,

started_in_foreground_);