Issue 213923002: Revert of Use UtilityProcessHost to patch files.

Issue 213923002: Revert of Use UtilityProcessHost to patch files. (Closed)

Created:
6 years, 9 months ago by erikchen

Modified:
6 years, 9 months ago

Reviewers:
waffles, Sorin Jianu, dgarrett, sky, Cris Neckar

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, cpu_(ooo_6.6-7.5), Lei Zhang

Base URL:
https://chromium.googlesource.com/chromium/src.git@nonblocking

Visibility:
Public.

More Reviews

Description

Revert of Use UtilityProcessHost to patch files. (https://codereview.chromium.org/25909005/) Reason for revert: linux asan failure http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%2BLSan%20Tests%20%282%29/builds/901/steps/unit_tests/logs/DifferentialUpdateFails Original issue's description: > Use UtilityProcessHost to patch files. > > Second part of a 2-part changelist. > The first part is https://codereview.chromium.org/25883006/ > > BUG=304879 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259726 TBR=sorin@chromium.org,dgarrett@chromium.org,sky@chromium.org,cdn@chromium.org,waffles@chromium.org NOTREECHECKS=true NOTRY=true BUG=304879 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259740

Patch Set 1 #

Created: 6 years, 9 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+557 lines, -702 lines)			Patch
M	chrome/browser/DEPS	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/component_updater/DEPS	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/component_updater/component_patcher.h	View	2 chunks	+43 lines, -51 lines	0 comments	Download
M	chrome/browser/component_updater/component_patcher.cc	View	2 chunks	+45 lines, -74 lines	0 comments	Download
M	chrome/browser/component_updater/component_patcher_operation.h	View	4 chunks	+57 lines, -108 lines	0 comments	Download
M	chrome/browser/component_updater/component_patcher_operation.cc	View	7 chunks	+89 lines, -251 lines	0 comments	Download
A	chrome/browser/component_updater/component_patcher_win.h	View	1 chunk	+28 lines, -0 lines	0 comments	Download
A	chrome/browser/component_updater/component_patcher_win.cc	View	1 chunk	+118 lines, -0 lines	0 comments	Download
M	chrome/browser/component_updater/component_unpacker.h	View	4 chunks	+13 lines, -13 lines	0 comments	Download
M	chrome/browser/component_updater/component_unpacker.cc	View	5 chunks	+21 lines, -19 lines	0 comments	Download
M	chrome/browser/component_updater/component_updater_configurator.cc	View	5 chunks	+16 lines, -4 lines	0 comments	Download
M	chrome/browser/component_updater/component_updater_service.h	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/component_updater/component_updater_service.cc	View	5 chunks	+11 lines, -9 lines	0 comments	Download
M	chrome/browser/component_updater/test/DEPS	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	chrome/browser/component_updater/test/component_patcher_mock.h	View	1 chunk	+32 lines, -0 lines	0 comments	Download
M	chrome/browser/component_updater/test/component_patcher_unittest.h	View	2 chunks	+1 line, -5 lines	0 comments	Download
M	chrome/browser/component_updater/test/component_patcher_unittest.cc	View	6 chunks	+68 lines, -90 lines	0 comments	Download
M	chrome/browser/component_updater/test/component_updater_service_unittest.h	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/component_updater/test/component_updater_service_unittest.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/chrome_tests_unit.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/chrome_utility_messages.h	View	3 chunks	+1 line, -24 lines	0 comments	Download
M	chrome/utility/DEPS	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/utility/chrome_content_utility_client.h	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	chrome/utility/chrome_content_utility_client.cc	View	3 chunks	+0 lines, -43 lines	0 comments	Download
M	content/content_utility.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

erikchen

Created Revert of Use UtilityProcessHost to patch files.

6 years, 9 months ago (2014-03-26 23:43:07 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erikchen@chromium.org/213923002/1

6 years, 9 months ago (2014-03-26 23:45:57 UTC) #2

Message was sent while issue was closed.

Change committed as 259740

Expand Messages | Collapse Messages