Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Unified Diff: src/register-allocator-ia32.cc

Issue 21392: Change compiler to safely write unsafe smis when they are spilled from... (Closed) Base URL: http://v8.googlecode.com/svn/branches/experimental/toiger/
Patch Set: '' Created 11 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/register-allocator-ia32.cc
===================================================================
--- src/register-allocator-ia32.cc (revision 1293)
+++ src/register-allocator-ia32.cc (working copy)
@@ -40,7 +40,11 @@
if (is_constant()) {
Result fresh = cgen_->allocator()->Allocate();
ASSERT(fresh.is_valid());
- cgen_->masm()->Set(fresh.reg(), Immediate(handle()));
+ if (cgen_->IsUnsafeSmi(handle())) {
+ cgen_->LoadUnsafeSmi(fresh.reg(), handle());
+ } else {
+ cgen_->masm()->Set(fresh.reg(), Immediate(handle()));
+ }
// This result becomes a copy of the fresh one.
*this = fresh;
}
@@ -57,7 +61,11 @@
cgen_->masm()->mov(fresh.reg(), reg());
} else {
ASSERT(is_constant());
- cgen_->masm()->Set(fresh.reg(), Immediate(handle()));
+ if (cgen_->IsUnsafeSmi(handle())) {
+ cgen_->LoadUnsafeSmi(fresh.reg(), handle());
+ } else {
+ cgen_->masm()->Set(fresh.reg(), Immediate(handle()));
+ }
}
*this = fresh;
} else if (is_register() && reg().is(target)) {
« src/codegen-ia32.cc ('K') | « src/codegen-ia32.cc ('k') | src/virtual-frame-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698