Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 2139193002: Fix the wrong value of kSmallImageMaskBackgroundColor (Closed)

Created:
4 years, 5 months ago by yoshiki
Modified:
4 years, 5 months ago
Reviewers:
Vitaly Baranov
CC:
chromium-reviews, Peter Beverloo, mlamouri+watch-notifications_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix the wrong value of kSmallImageMaskBackgroundColor It was changed wrongly by crrev.com/395903. This patch fixes this. BUG=none Committed: https://crrev.com/d89df423535ff16397e117fc2ffc4965d1a54ba9 Cr-Commit-Position: refs/heads/master@{#405145}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ui/message_center/message_center_style.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (7 generated)
yoshiki
Vitaly, PTAL.
4 years, 5 months ago (2016-07-12 07:09:34 UTC) #3
Vitaly Baranov
LGTM
4 years, 5 months ago (2016-07-12 11:00:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2139193002/1
4 years, 5 months ago (2016-07-12 15:55:53 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/242656)
4 years, 5 months ago (2016-07-12 17:35:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2139193002/1
4 years, 5 months ago (2016-07-13 13:45:57 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-13 14:33:56 UTC) #12
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-13 14:34:03 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 14:37:12 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d89df423535ff16397e117fc2ffc4965d1a54ba9
Cr-Commit-Position: refs/heads/master@{#405145}

Powered by Google App Engine
This is Rietveld 408576698