Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Issue 2139183002: [turbofan] Unify BooleanToNumber, StringToNumber and PlainPrimitiveToNumber. (Closed)

Created:
4 years, 5 months ago by Benedikt Meurer
Modified:
4 years, 5 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Unify BooleanToNumber, StringToNumber and PlainPrimitiveToNumber. The PlainPrimitiveToNumber operator performs a superset of the operations previously performed by the BooleanToNumber and StringToNumber operators, so we can just use the special lowering rules for PlainPrimitiveToNumber based on the input type and get rid of the specialized operators. R=jarin@chromium.org Committed: https://crrev.com/85969edead72426d6da6a387dba2480ad0b578e0 Cr-Commit-Position: refs/heads/master@{#37669}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -134 lines) Patch
M src/compiler/js-typed-lowering.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M src/compiler/opcodes.h View 2 chunks +0 lines, -2 lines 0 comments Download
M src/compiler/simplified-lowering.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 5 chunks +22 lines, -38 lines 0 comments Download
M src/compiler/simplified-operator.h View 2 chunks +0 lines, -2 lines 0 comments Download
M src/compiler/simplified-operator.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M src/compiler/typer.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M src/compiler/verifier.cc View 3 chunks +7 lines, -12 lines 0 comments Download
M test/cctest/compiler/test-js-typed-lowering.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M test/cctest/compiler/test-simplified-lowering.cc View 1 chunk +0 lines, -57 lines 0 comments Download
M test/unittests/compiler/simplified-operator-unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
Benedikt Meurer
4 years, 5 months ago (2016-07-12 05:15:43 UTC) #1
Benedikt Meurer
Hey Jaro, Some cleanup/unification on the ToNumber front. Please take a look. Thanks, Benedikt
4 years, 5 months ago (2016-07-12 05:16:31 UTC) #4
Jarin
lgtm
4 years, 5 months ago (2016-07-12 08:54:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2139183002/1
4 years, 5 months ago (2016-07-12 09:10:07 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-12 09:12:26 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-12 09:15:20 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/85969edead72426d6da6a387dba2480ad0b578e0
Cr-Commit-Position: refs/heads/master@{#37669}

Powered by Google App Engine
This is Rietveld 408576698