Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Issue 2139163002: Animations: Remove player.html test (Closed)

Created:
4 years, 5 months ago by samli
Modified:
4 years, 5 months ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Animations: Remove player.html test Test is broken (see expectations), used outdated APIs (eg. timelag), is duplicated by W3C tests and basic IDL checks. BUG=623437 Committed: https://crrev.com/0a2a0b2dbcc139d344271994cbdfc1d7f3726746 Cr-Commit-Position: refs/heads/master@{#404782}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -59 lines) Patch
D third_party/WebKit/LayoutTests/web-animations-api/player.html View 1 chunk +0 lines, -53 lines 0 comments Download
D third_party/WebKit/LayoutTests/web-animations-api/player-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
samli
4 years, 5 months ago (2016-07-12 02:05:18 UTC) #3
suzyh_UTC10 (ex-contributor)
lgtm Nit: Typo in CL description "Test was longer valid"?
4 years, 5 months ago (2016-07-12 02:09:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2139163002/1
4 years, 5 months ago (2016-07-12 02:25:39 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-12 04:13:24 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-12 04:13:51 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-12 04:14:56 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0a2a0b2dbcc139d344271994cbdfc1d7f3726746
Cr-Commit-Position: refs/heads/master@{#404782}

Powered by Google App Engine
This is Rietveld 408576698