Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2139153002: Prepare animation-*-ready-finished-ordering for upstreaming (Closed)

Created:
4 years, 5 months ago by dstockwell
Modified:
4 years, 5 months ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prepare animation-*-ready-finished-ordering for upstreaming BUG=623437 Committed: https://crrev.com/81b734ca4f896a38d51fe9a9d59810db0211904b Cr-Commit-Position: refs/heads/master@{#405091}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -39 lines) Patch
A third_party/WebKit/LayoutTests/web-animations-api/animation-cancel-ready-finished-ordering.html View 1 chunk +24 lines, -0 lines 1 comment Download
A third_party/WebKit/LayoutTests/web-animations-api/animation-finish-ready-finished-ordering.html View 1 chunk +25 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/web-animations-api/player-ready-finished-ordering.html View 1 chunk +0 lines, -39 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
dstockwell
4 years, 5 months ago (2016-07-12 01:56:45 UTC) #2
suzyh_UTC10 (ex-contributor)
lgtm
4 years, 5 months ago (2016-07-12 02:08:09 UTC) #3
alancutter (OOO until 2018)
https://codereview.chromium.org/2139153002/diff/1/third_party/WebKit/LayoutTests/web-animations-api/animation-cancel-ready-finished-ordering.html File third_party/WebKit/LayoutTests/web-animations-api/animation-cancel-ready-finished-ordering.html (right): https://codereview.chromium.org/2139153002/diff/1/third_party/WebKit/LayoutTests/web-animations-api/animation-cancel-ready-finished-ordering.html#newcode16 third_party/WebKit/LayoutTests/web-animations-api/animation-cancel-ready-finished-ordering.html:16: animation.finished.then(null, function() { These should be .catch instead of ...
4 years, 5 months ago (2016-07-12 06:18:12 UTC) #4
suzyh_UTC10 (ex-contributor)
On 2016/07/12 at 06:18:12, alancutter wrote: > https://codereview.chromium.org/2139153002/diff/1/third_party/WebKit/LayoutTests/web-animations-api/animation-cancel-ready-finished-ordering.html > File third_party/WebKit/LayoutTests/web-animations-api/animation-cancel-ready-finished-ordering.html (right): > > https://codereview.chromium.org/2139153002/diff/1/third_party/WebKit/LayoutTests/web-animations-api/animation-cancel-ready-finished-ordering.html#newcode16 ...
4 years, 5 months ago (2016-07-13 07:31:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2139153002/1
4 years, 5 months ago (2016-07-13 07:32:32 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-13 08:48:21 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-13 08:48:24 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 08:49:40 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/81b734ca4f896a38d51fe9a9d59810db0211904b
Cr-Commit-Position: refs/heads/master@{#405091}

Powered by Google App Engine
This is Rietveld 408576698