Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5758)

Unified Diff: chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer_unittest.cc

Issue 2139143002: Standardize which page loads are tracked (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add tests Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer_unittest.cc
diff --git a/chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer_unittest.cc b/chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer_unittest.cc
index 3557d722926ec92f20a532e3c0e7ee9ddbec1b57..8a1c61778cea6c80335479cb87a829bb7e7bd233 100644
--- a/chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer_unittest.cc
+++ b/chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer_unittest.cc
@@ -29,6 +29,25 @@ TEST_F(AbortsPageLoadMetricsObserverTest, UnknownNavigationBeforeCommit) {
internal::kHistogramAbortUnknownNavigationBeforeCommit, 1);
}
+TEST_F(AbortsPageLoadMetricsObserverTest,
+ UnknownProvisionalNavigationBeforeCommit) {
+ StartNavigation(GURL("https://www.google.com"));
+ StartNavigation(GURL("https://www.example.com"));
+ histogram_tester().ExpectTotalCount(
+ internal::kHistogramAbortUnknownNavigationBeforeCommit, 1);
+}
+
+TEST_F(AbortsPageLoadMetricsObserverTest,
+ UnknownNavigationBeforeCommitNonTrackedPageLoad) {
+ StartNavigation(GURL("https://www.google.com"));
+ // Simulate the user performing another navigation before commit. Navigate to
+ // an untracked URL, to verify that we still log abort metrics even if the new
+ // navigation isn't tracked.
+ NavigateAndCommit(GURL("about:blank"));
+ histogram_tester().ExpectTotalCount(
+ internal::kHistogramAbortUnknownNavigationBeforeCommit, 1);
+}
+
TEST_F(AbortsPageLoadMetricsObserverTest, NewNavigationBeforePaint) {
NavigateAndCommit(GURL("https://www.google.com"));
SimulateTimingWithoutPaint();
« no previous file with comments | « no previous file | chrome/browser/page_load_metrics/observers/https_engagement_metrics/https_engagement_page_load_metrics_observer_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698