Standardize which page loads are tracked

components/page_load_metrics/browser/metrics_web_contents_observer.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_PAGE_LOAD_METRICS_BROWSER_METRICS_WEB_CONTENTS_OBSERVER_H_
 #define COMPONENTS_PAGE_LOAD_METRICS_BROWSER_METRICS_WEB_CONTENTS_OBSERVER_H_
 
 #include <map>
 #include <memory>
 #include <vector>
@@ skipping 127 matching lines @@
   void WebContentsShown();
 
   void OnInputEvent(const blink::WebInputEvent& event);
 
   void NotifyClientRedirectTo(const PageLoadTracker& destination);
 
   // Returns true if the timing was successfully updated.
   bool UpdateTiming(const PageLoadTiming& timing,
                     const PageLoadMetadata& metadata);
 
-  void set_renderer_tracked(bool renderer_tracked);
-  bool renderer_tracked() const { return renderer_tracked_; }
+  // Signals that we should stop tracking metrics for the associated page load.
+  // We may stop tracking a page load if it doesn't meet the criteria for
+  // tracking metrics in DidFinishNavigation.
+  void StopTracking();
 
   int aborted_chain_size() const { return aborted_chain_size_; }
   int aborted_chain_size_same_url() const {
     return aborted_chain_size_same_url_;
   }
 
   UserAbortType abort_type() const { return abort_type_; }
   base::TimeTicks abort_time() const { return abort_time_; }
 
   void AddObserver(std::unique_ptr<PageLoadMetricsObserver> observer);
@@ skipping 42 matching lines @@
 
   void UpdateAbortInternal(UserAbortType abort_type,
                            base::TimeTicks timestamp,
                            bool is_certainly_browser_timestamp);
 
   // If |final_navigation| is null, then this is an "unparented" abort chain,
   // and represents a sequence of provisional aborts that never ends with a
   // committed load.
   void LogAbortChainHistograms(content::NavigationHandle* final_navigation);
 
-  // Whether the renderer should be sending timing IPCs to this page load.
-  bool renderer_tracked_;
+  // Whether we stopped tracking this navigation after it was initiated. We may
+  // stop tracking a navigation if it doesn't meet the criteria for tracking
+  // metrics in DidFinishNavigation.
+  bool did_stop_tracking_;
 
   // The navigation start in TimeTicks, not the wall time reported by Blink.
   const base::TimeTicks navigation_start_;
 
   // Time this page load was committed. If this page load hasn't committed,
   // |commit_time_| will be zero.
   base::TimeTicks commit_time_;
 
   // The URL of this page load. This is the provisional url before commit
   // (before redirects), and the committed url after commit.
@@ skipping 67 matching lines @@
   void RenderProcessGone(base::TerminationStatus status) override;
   void RenderViewHostChanged(content::RenderViewHost* old_host,
                              content::RenderViewHost* new_host) override;
 
   // This getter function is required for testing.
   const PageLoadExtraInfo GetPageLoadExtraInfoForCommittedLoad();
 
  private:
   friend class content::WebContentsUserData<MetricsWebContentsObserver>;
 
+  void HandleFailedNavigationForTrackedLoad(
+      content::NavigationHandle* navigation_handle,
+      std::unique_ptr<PageLoadTracker> tracker);
+
+  void HandleCommittedNavigationForTrackedLoad(
+      content::NavigationHandle* navigation_handle,
+      std::unique_ptr<PageLoadTracker> tracker);
+
   // Notify all loads, provisional and committed, that we performed an action
   // that might abort them.
   void NotifyAbortAllLoads(UserAbortType abort_type);
   void NotifyAbortAllLoadsWithTimestamp(UserAbortType abort_type,
                                         base::TimeTicks timestamp,
                                         bool is_certainly_browser_timestamp);
 
   // Register / Unregister input event callback to given RenderViewHost
   void RegisterInputEventObserver(content::RenderViewHost* host);
   void UnregisterInputEventObserver(content::RenderViewHost* host);
 
   // Notify aborted provisional loads that a new navigation occurred. This is
   // used for more consistent attribution tracking for aborted provisional
   // loads. This method returns the provisional load that was likely aborted
   // by this navigation, to help instantiate the new PageLoadTracker.
   std::unique_ptr<PageLoadTracker> NotifyAbortedProvisionalLoadsNewNavigation(
       content::NavigationHandle* new_navigation);
 
   void OnTimingUpdated(content::RenderFrameHost*,
                        const PageLoadTiming& timing,
                        const PageLoadMetadata& metadata);
 
+  bool ShouldTrackNavigation(
+      content::NavigationHandle* navigation_handle) const;
+
   // True if the web contents is currently in the foreground.
   bool in_foreground_;
 
   // The PageLoadTrackers must be deleted before the |embedder_interface_|,
   // because they hold a pointer to the |embedder_interface_|.
   std::unique_ptr<PageLoadMetricsEmbedderInterface> embedder_interface_;
 
   // This map tracks all of the navigations ongoing that are not committed
   // yet. Once a navigation is committed, it moves from the map to
   // committed_load_. Note that a PageLoadTrackers NavigationHandle is only
@@ skipping 12 matching lines @@
 
   // Has the MWCO observed at least one navigation?
   bool has_navigated_;
 
   DISALLOW_COPY_AND_ASSIGN(MetricsWebContentsObserver);
 };
 
 }  // namespace page_load_metrics
 
 #endif  // COMPONENTS_PAGE_LOAD_METRICS_BROWSER_METRICS_WEB_CONTENTS_OBSERVER_H_