chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc - Issue 2139143002: Standardize which page loads are tracked

Side by Side Diff: chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc

Issue 2139143002: Standardize which page loads are tracked (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add tests Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/page_load_metrics/observers/https_engagement_metrics/https_engagement_page_load_metrics_observer_browsertest.cc ('k') | components/page_load_metrics/browser/metrics_web_contents_observer.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2015 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "base/macros.h"	5 #include "base/macros.h"

6 #include "base/test/histogram_tester.h"	6 #include "base/test/histogram_tester.h"

7 #include "chrome/browser/page_load_metrics/observers/core_page_load_metrics_obse rver.h"	7 #include "chrome/browser/page_load_metrics/observers/core_page_load_metrics_obse rver.h"

8 #include "chrome/browser/page_load_metrics/observers/document_write_page_load_me trics_observer.h"	8 #include "chrome/browser/page_load_metrics/observers/document_write_page_load_me trics_observer.h"

9 #include "chrome/test/base/in_process_browser_test.h"	9 #include "chrome/test/base/in_process_browser_test.h"

10 #include "chrome/test/base/ui_test_utils.h"	10 #include "chrome/test/base/ui_test_utils.h"

(...skipping 27 matching lines...) Expand all Loading...
38 embedded_test_server()->GetURL("/title2.html"));	38 embedded_test_server()->GetURL("/title2.html"));

39	39

40 histogram_tester_.ExpectTotalCount(internal::kHistogramDomContentLoaded, 1);	40 histogram_tester_.ExpectTotalCount(internal::kHistogramDomContentLoaded, 1);

41 histogram_tester_.ExpectTotalCount(internal::kHistogramLoad, 1);	41 histogram_tester_.ExpectTotalCount(internal::kHistogramLoad, 1);

42 histogram_tester_.ExpectTotalCount(internal::kHistogramFirstLayout, 1);	42 histogram_tester_.ExpectTotalCount(internal::kHistogramFirstLayout, 1);

43 histogram_tester_.ExpectTotalCount(internal::kHistogramParseDuration, 1);	43 histogram_tester_.ExpectTotalCount(internal::kHistogramParseDuration, 1);

44 histogram_tester_.ExpectTotalCount(	44 histogram_tester_.ExpectTotalCount(

45 internal::kHistogramParseBlockedOnScriptLoad, 1);	45 internal::kHistogramParseBlockedOnScriptLoad, 1);

46 }	46 }

47	47

48 IN_PROC_BROWSER_TEST_F(MetricsWebContentsObserverBrowserTest, AnchorLink) {	48 IN_PROC_BROWSER_TEST_F(MetricsWebContentsObserverBrowserTest,

	49 SamePageNavigation) {

49 ASSERT_TRUE(embedded_test_server()->Start());	50 ASSERT_TRUE(embedded_test_server()->Start());

50	51

51 ui_test_utils::NavigateToURL(browser(),	52 ui_test_utils::NavigateToURL(browser(),

52 embedded_test_server()->GetURL("/title1.html"));	53 embedded_test_server()->GetURL("/title1.html"));

53 ui_test_utils::NavigateToURL(	54 ui_test_utils::NavigateToURL(

54 browser(), embedded_test_server()->GetURL("/title1.html#hash"));	55 browser(), embedded_test_server()->GetURL("/title1.html#hash"));

55 ui_test_utils::NavigateToURL(browser(),	56 ui_test_utils::NavigateToURL(browser(),

56 embedded_test_server()->GetURL("/title2.html"));	57 embedded_test_server()->GetURL("/title2.html"));

57	58

58 histogram_tester_.ExpectTotalCount(internal::kHistogramDomContentLoaded, 1);	59 histogram_tester_.ExpectTotalCount(internal::kHistogramDomContentLoaded, 1);

(...skipping 121 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
180	181

181 ui_test_utils::NavigateToURL(	182 ui_test_utils::NavigateToURL(

182 browser(), embedded_test_server()->GetURL(	183 browser(), embedded_test_server()->GetURL(

183 "/page_load_metrics/document_write_no_script.html"));	184 "/page_load_metrics/document_write_no_script.html"));

184 ui_test_utils::NavigateToURL(browser(),	185 ui_test_utils::NavigateToURL(browser(),

185 embedded_test_server()->GetURL("/title2.html"));	186 embedded_test_server()->GetURL("/title2.html"));

186	187

187 histogram_tester_.ExpectTotalCount(	188 histogram_tester_.ExpectTotalCount(

188 internal::kHistogramDocWriteBlockParseStartToFirstContentfulPaint, 0);	189 internal::kHistogramDocWriteBlockParseStartToFirstContentfulPaint, 0);

189 }	190 }

OLD	NEW