Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 2139133002: Check theme color when updating toolbar assets (Closed)

Created:
4 years, 5 months ago by mdjones
Modified:
4 years, 5 months ago
Reviewers:
Yusuf
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Check theme color when updating toolbar assets Since tabs can now be restored with a theme color in use, that color should be considered when initializing the tab switcher icon. BUG=627091 Committed: https://crrev.com/34000a697fcb9652726b4169bd15fdd7dc22206b Cr-Commit-Position: refs/heads/master@{#404828}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java View 1 chunk +10 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
mdjones
ptal
4 years, 5 months ago (2016-07-12 01:26:01 UTC) #2
Yusuf
lgtm
4 years, 5 months ago (2016-07-12 17:45:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2139133002/1
4 years, 5 months ago (2016-07-12 18:34:20 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-12 20:23:43 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-12 20:25:38 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/34000a697fcb9652726b4169bd15fdd7dc22206b
Cr-Commit-Position: refs/heads/master@{#404828}

Powered by Google App Engine
This is Rietveld 408576698