Issue 213913002: win_toolchain: Note that google.com credentials are required

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 213913002: win_toolchain: Note that google.com credentials are required (Closed)

Created:
6 years, 8 months ago by scottmg

Modified:
6 years, 8 months ago

Reviewers:
Mike Lawther (Google), iannucci

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org, hinoka

Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Visibility:
Public.

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	win_toolchain/get_toolchain_if_necessary.py	View		1 chunk	+4 lines, -2 lines	0 comments	Download

Total messages: 4 (0 generated)

Mike Lawther (Google)

On 2014/03/26 23:45:00, scottmg wrote: lgtm. Perhaps also suggest using an incognito window, just to ...

6 years, 8 months ago (2014-03-26 23:50:38 UTC) #2

scottmg

6 years, 8 months ago (2014-03-27 16:50:42 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r259915 (presubmit successful).