Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2139113002:
Add the relevant information to the test and use testcommon.js (Closed)
|
Created:
4 years, 5 months ago by nainar Modified:
4 years, 5 months ago Reviewers:
alancutter (OOO until 2018) CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd the relevant information to the test and use testcommon.js
BUG=623437
Committed: https://crrev.com/21808e254d52527520140a488003ac32d56a9a72
Cr-Commit-Position: refs/heads/master@{#404785}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Use testcommon.js #
Total comments: 4
Patch Set 3 : Respond to Alan's comments #Messages
Total messages: 14 (6 generated)
Description was changed from ========== add header BUG= ========== to ========== Add the relevant information to the test BUG=623437 ==========
nainar@chromium.org changed reviewers: + alancutter@chromium.org
https://codereview.chromium.org/2139113002/diff/1/third_party/WebKit/LayoutTe... File third_party/WebKit/LayoutTests/web-animations-api/delay-endDelay-phases.html (right): https://codereview.chromium.org/2139113002/diff/1/third_party/WebKit/LayoutTe... third_party/WebKit/LayoutTests/web-animations-api/delay-endDelay-phases.html:12: let target = document.createElement('div'); We should probably be using https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/imported/....
Description was changed from ========== Add the relevant information to the test BUG=623437 ========== to ========== Add the relevant information to the test and use testcommon.js BUG=623437 ==========
PTAL? Thanks! https://codereview.chromium.org/2139113002/diff/1/third_party/WebKit/LayoutTe... File third_party/WebKit/LayoutTests/web-animations-api/delay-endDelay-phases.html (right): https://codereview.chromium.org/2139113002/diff/1/third_party/WebKit/LayoutTe... third_party/WebKit/LayoutTests/web-animations-api/delay-endDelay-phases.html:12: let target = document.createElement('div'); Done.
lgtm with nit. https://codereview.chromium.org/2139113002/diff/20001/third_party/WebKit/Layo... File third_party/WebKit/LayoutTests/web-animations-api/delay-endDelay-phases.html (right): https://codereview.chromium.org/2139113002/diff/20001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/web-animations-api/delay-endDelay-phases.html:11: test((t) => { No need for brackets around t.
https://codereview.chromium.org/2139113002/diff/20001/third_party/WebKit/Layo... File third_party/WebKit/LayoutTests/web-animations-api/delay-endDelay-phases.html (right): https://codereview.chromium.org/2139113002/diff/20001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/web-animations-api/delay-endDelay-phases.html:8: <div id="container"></div> No need for container any more, createDiv() appends to the document.
https://codereview.chromium.org/2139113002/diff/20001/third_party/WebKit/Layo... File third_party/WebKit/LayoutTests/web-animations-api/delay-endDelay-phases.html (right): https://codereview.chromium.org/2139113002/diff/20001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/web-animations-api/delay-endDelay-phases.html:8: <div id="container"></div> Replaced with body cause you do need a container for createDiv() https://codereview.chromium.org/2139113002/diff/20001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/web-animations-api/delay-endDelay-phases.html:11: test((t) => { Done.
The CQ bit was checked by nainar@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from alancutter@chromium.org Link to the patchset: https://codereview.chromium.org/2139113002/#ps40001 (title: "Respond to Alan's comments")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Add the relevant information to the test and use testcommon.js BUG=623437 ========== to ========== Add the relevant information to the test and use testcommon.js BUG=623437 Committed: https://crrev.com/21808e254d52527520140a488003ac32d56a9a72 Cr-Commit-Position: refs/heads/master@{#404785} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/21808e254d52527520140a488003ac32d56a9a72 Cr-Commit-Position: refs/heads/master@{#404785} |
