Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issue 2139103002: Revert of Fix bootstrap on windows (Closed)

Created:
4 years, 5 months ago by martiniss
Modified:
4 years, 5 months ago
Reviewers:
dnj
CC:
chromium-reviews, infra-reviews+recipes-py_chromium.org
Base URL:
https://chromium.googlesource.com/external/github.com/luci/recipes-py@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert of Fix bootstrap on windows (patchset #2 id:20001 of https://codereview.chromium.org/2136303002/ ) Reason for revert: Appears to have broken the roller... :( Original issue's description: > Fix bootstrap on windows > > Also uses ROOT_DIR instead of hardcoding the value. > > R=dnj > > Committed: https://github.com/luci/recipes-py/commit/ce485a8a394dcc1561b5ecdd337a85002083de5b TBR=dnj@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://github.com/luci/recipes-py/commit/ba76686b6729174d9b7c7900ada4946ea5329632

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6 lines) Patch
M recipes.py View 2 chunks +4 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
martiniss
Created Revert of Fix bootstrap on windows
4 years, 5 months ago (2016-07-12 00:41:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2139103002/1
4 years, 5 months ago (2016-07-12 00:41:40 UTC) #3
commit-bot: I haz the power
4 years, 5 months ago (2016-07-12 00:41:47 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/recipes-py/commit/ba76686b6729174d9b7c7900ada4946ea53...

Powered by Google App Engine
This is Rietveld 408576698