[Findit] Trigger swarming tasks after detech_first_faliure_pipeline

appengine/findit/waterfall/detect_first_failure_pipeline.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import base64
 import json
 
 from common import constants
 from common.http_client_appengine import HttpClientAppengine as HttpClient
 from common.pipeline_wrapper import BasePipeline
 from common.pipeline_wrapper import pipeline
 from common.waterfall import failure_type
 from model.wf_analysis import WfAnalysis
 from model.wf_step import WfStep
 from waterfall import build_util
 from waterfall import buildbot
 from waterfall import swarming_util
 
 
 _MAX_BUILDS_TO_CHECK = 20
 _NON_FAILURE_STATUS = ['SUCCESS', 'SKIPPED', 'UNKNOWN']
+_PRE_TEST_PREFIX = 'PRE_'
+
+
+def _RemoveAnyPrefixes(test):

[lijeffrey, 2016/07/12 22:36:27]

Nit: should this be renamed to _RemoveAllPrefixes, since the while loop in line
40 seems to remove all of them?

[chanli, 2016/07/12 22:54:56]

Done.

+  """Remove prefixes from test names.
+
+  Args:
+    test (str): A test's name, eg: 'suite1.PRE_test1'.
+
+  Returns:
+    base_test (str): A base test name, eg: 'suite1.test1'.
+  """
+  test_name_start = test.find('.') if test.find('.') > -1 else 0

[lijeffrey, 2016/07/12 22:36:27]

I think we can do this with just 1 call to test.find() by doing something like

test_name_start = max(test.find('.'), 0)

[chanli, 2016/07/12 22:54:56]

Good idea. Done

+  if test_name_start == 0:
+    return test

[lijeffrey, 2016/07/12 22:36:27]

nit: 1 empty line after return test

[chanli, 2016/07/12 22:54:56]

Done.

+  test_suite = test[ : test_name_start]

[lijeffrey, 2016/07/12 22:36:28]

nit: is the extra space in 'test[ :' necessary? Same with line 38

[chanli, 2016/07/12 22:54:56]

I honestly don't know... I'll remove them for now.

+  test_name = test[test_name_start + 1 : ]
+  pre_position = test_name.find(_PRE_TEST_PREFIX)
+  while pre_position == 0:
+    test_name = test_name[len(_PRE_TEST_PREFIX):]
+    pre_position = test_name.find(_PRE_TEST_PREFIX)
+  base_test = test_suite + '.' + test_name

[lijeffrey, 2016/07/12 22:36:28]

nit: How about

base_test = '%s.%s' % (test_suite, test_name)?

I think using %s should be more robust than the + operator which breaks if
anything is None

[chanli, 2016/07/12 22:54:56]

Done.

+  return base_test
 
 
 class DetectFirstFailurePipeline(BasePipeline):
   """A pipeline to detect first failure of each step.
 
   TODO(stgao): do test-level detection for gtest.
   """
 
   def _ExtractBuildInfo(self, master_name, builder_name, build_number):
     """Returns a BuildInfo instance for the specified build."""
@@ skipping 156 matching lines @@
           # If a test is skipped, that means it was not run at all.
           # Treats it as success since the status cannot be determined.
           is_reliable_failure = False
 
         if is_reliable_failure:
           if failed_step:
             # Adds the test to failed_step.
             failed_step['tests'][test_name] = {
                 'current_failure': failed_step['current_failure'],
                 'first_failure': failed_step['current_failure'],
+                'base_test_name': _RemoveAnyPrefixes(test_name)
             }
             if failed_step.get('last_pass'):
               failed_step['tests'][test_name]['last_pass'] = (
                   failed_step['last_pass'])
           # Stores the output to the step's log_data later.
           failed_test_log[test_name] = ''
           for test in iteration[test_name]:
             failed_test_log[test_name] = self._ConcatenateTestLog(
                 failed_test_log[test_name], test.get(
                     'output_snippet_base64', ''))
@@ skipping 258 matching lines @@
 
     failure_info['builds'] = builds
     failure_info['failed_steps'] = failed_steps
 
     analysis = WfAnalysis.Get(master_name, builder_name, build_number)
     analysis.not_passed_steps = build_info.not_passed_steps
     analysis.build_failure_type = build_failure_type
     analysis.put()
 
     return failure_info