[Findit] Trigger swarming tasks after detech_first_faliure_pipeline

appengine/findit/model/wf_analysis.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from google.appengine.ext import ndb
 
 from common import constants
 from common.waterfall import failure_type
 from model.base_build_model import BaseBuildModel
 from model import analysis_status
 from model import result_status
 
 
 class WfAnalysis(BaseBuildModel):
   """Represents an analysis of a build of a builder in a Chromium waterfall.
 
   'Wf' is short for waterfall.
   """
   @staticmethod
   def _CreateKey(master_name, builder_name, build_number):  # pragma: no cover
     return ndb.Key('WfAnalysis',
                    BaseBuildModel.CreateBuildId(
                        master_name, builder_name, build_number))
 
   @staticmethod
   def Create(master_name, builder_name, build_number):  # pragma: no cover
-    return WfAnalysis(
+    analysis = WfAnalysis(
         key=WfAnalysis._CreateKey(master_name, builder_name, build_number))
+    if analysis.failure_result_map is None:
+      analysis.failure_result_map = {}

[lijeffrey, 2016/07/12 22:36:27]

I think this can be simplified slightly with

analysis.failure_result_map = analysis.failure_result_map or {}

[chanli, 2016/07/12 22:54:56]

Done.

+    return analysis
 
   @staticmethod
   def Get(master_name, builder_name, build_number):  # pragma: no cover
     return WfAnalysis._CreateKey(master_name, builder_name, build_number).get()
 
   @property
   def completed(self):
     return self.status in (
         analysis_status.COMPLETED, analysis_status.ERROR)
 
@@ skipping 107 matching lines @@
   suspected_cls = ndb.JsonProperty(indexed=False, compressed=True)
   # Record the id of try job results of each failure.
   failure_result_map = ndb.JsonProperty(indexed=False, compressed=True)
 
   # The actual culprit CLs that are responsible for the failures.
   culprit_cls = ndb.JsonProperty(indexed=False, compressed=True)
   # Conclusion of analysis result for the build failure: 'Found' or 'Not Found'.
   result_status = ndb.IntegerProperty(indexed=True)
   # Record the history of triage.
   triage_history = ndb.JsonProperty(indexed=False, compressed=True)