[Findit] Trigger swarming tasks after detech_first_faliure_pipeline

appengine/findit/waterfall/test/detect_first_failure_pipeline_test.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import datetime
 import json
 import os
 import urllib
 import zlib
 
 from common.http_client_appengine import HttpClientAppengine as HttpClient
 from common.pipeline_wrapper import pipeline_handlers
 from common.waterfall import failure_type
 from model import analysis_status
 from model.wf_analysis import WfAnalysis
 from model.wf_build import WfBuild
 from model.wf_step import WfStep
 from waterfall import buildbot
+from waterfall import detect_first_failure_pipeline
 from waterfall import lock_util
 from waterfall import swarming_util
 from waterfall.build_info import BuildInfo
 from waterfall.detect_first_failure_pipeline import DetectFirstFailurePipeline
 from waterfall.test import wf_testcase
 
 
 class DetectFirstFailureTest(wf_testcase.WaterfallTestCase):
   app_module = pipeline_handlers._APP
 
@@ skipping 274 matching lines @@
     pipeline = DetectFirstFailurePipeline()
     pipeline._InitiateTestLevelFirstFailureAndSaveLog(
         json_data, step, failed_step)
 
     expected_failed_step = {
         'current_failure': 223,
         'first_failure': 221,
         'tests': {
             'Unittest2.Subtest1': {
                 'current_failure': 223,
-                'first_failure': 223
+                'first_failure': 223,
+                'base_test_name': 'Unittest2.Subtest1'
             },
             'Unittest3.Subtest2': {
                 'current_failure': 223,
                 'first_failure': 223,
+                'base_test_name': 'Unittest3.Subtest2'
             }
         }
     }
 
     self.assertEqual(expected_failed_step, failed_step)
 
   def testCheckFirstKnownFailureForSwarmingTestsFoundFlaky(self):
     master_name = 'm'
     builder_name = 'b'
     build_number = 221
@@ skipping 55 matching lines @@
     builder_name = 'b'
     build_number = 223
     step_name = 'abc_test'
     failed_step = {
         'current_failure': 223,
         'first_failure': 221,
         'tests': {
             'Unittest2.Subtest1': {
                 'current_failure': 223,
                 'first_failure': 223,
-                'last_pass': 223
+                'last_pass': 223,
+                'base_test_name': 'Unittest2.Subtest1'
             },
             'Unittest3.Subtest2': {
                 'current_failure': 223,
-                'first_failure': 223
+                'first_failure': 223,
+                'base_test_name': 'Unittest3.Subtest2'
             }
         }
     }
 
     for n in xrange(222, 220, -1):
       # Mock retrieving data from swarming server for a single step.
       self._MockUrlFetchWithSwarmingData(
           master_name, builder_name, n, 'abc_test')
 
       # Mock retrieving hash to output.json from isolated server.
@@ skipping 29 matching lines @@
         master_name, builder_name, build_number, step_name, failed_step,
         HttpClient())
 
     expected_failed_step = {
         'current_failure': 223,
         'first_failure': 221,
         'tests': {
             'Unittest2.Subtest1': {
                 'current_failure': 223,
                 'first_failure': 222,
-                'last_pass': 221
+                'last_pass': 221,
+                'base_test_name': 'Unittest2.Subtest1'
             },
             'Unittest3.Subtest2': {
                 'current_failure': 223,
-                'first_failure': 221
+                'first_failure': 221,
+                'base_test_name': 'Unittest3.Subtest2'
             }
         }
     }
     self.assertEqual(expected_failed_step, failed_step)
 
   def testUpdateFirstFailureOnTestLevelFlaky(self):
     master_name = 'm'
     builder_name = 'b'
     build_number = 223
     step_name = 'abc_test'
     failed_step = {
         'current_failure': 223,
         'first_failure': 221,
         'tests': {
             'Unittest2.Subtest1': {
                 'current_failure': 223,
                 'first_failure': 223,
-                'last_pass': 223
+                'last_pass': 223,
+                'base_test_name': 'Unittest2.Subtest1'
             }
         }
     }
     step = WfStep.Create(master_name, builder_name, 222, step_name)
     step.isolated = True
     step.log_data = 'flaky'
     step.put()
 
     pipeline = DetectFirstFailurePipeline()
     pipeline._UpdateFirstFailureOnTestLevel(
         master_name, builder_name, build_number, step_name, failed_step,
         HttpClient())
 
     expected_failed_step = {
         'current_failure': 223,
         'first_failure': 223,
         'last_pass': 222,
         'tests': {
             'Unittest2.Subtest1': {
                 'current_failure': 223,
                 'first_failure': 223,
-                'last_pass': 222
+                'last_pass': 222,
+                'base_test_name': 'Unittest2.Subtest1'
             }
         }
     }
     self.assertEqual(expected_failed_step, failed_step)
 
   def testUpdateFailureInfoBuildsUpdateBuilds(self):
     failed_steps = {
         'compile': {
             'current_failure': 223,
             'first_failure': 222,
             'last_pass': 221
         },
         'abc_test': {
             'current_failure': 223,
             'first_failure': 222,
             'last_pass': 221,
             'list_isolated_data': [
                 {
                     'isolatedserver': 'https://isolateserver.appspot.com',
                     'namespace': 'default-gzip',
                     'digest': 'isolatedhashabctest-223'
                 }
             ],
             'tests': {
                 'Unittest2.Subtest1': {
                     'current_failure': 223,
                     'first_failure': 222,
-                    'last_pass': 221
+                    'last_pass': 221,
+                    'base_test_name': 'Unittest2.Subtest1'
                 },
                 'Unittest3.Subtest2': {
                     'current_failure': 223,
                     'first_failure': 222,
-                    'last_pass': 221
+                    'last_pass': 221,
+                    'base_test_name': 'Unittest3.Subtest2'
                 }
             }
         }
     }
 
     builds = {
         '220': {
             'blame_list': ['commit0'],
             'chromium_revision': 'commit0'
         },
@@ skipping 94 matching lines @@
                 {
                     'isolatedserver': 'https://isolateserver.appspot.com',
                     'namespace': 'default-gzip',
                     'digest': 'isolatedhashabctest-223'
                 }
             ],
             'tests': {
                 'Unittest2.Subtest1': {
                     'current_failure': 223,
                     'first_failure': 222,
-                    'last_pass': 221
+                    'last_pass': 221,
+                    'base_test_name': 'Unittest2.Subtest1'
                 },
                 'Unittest3.Subtest2': {
                     'current_failure': 223,
                     'first_failure': 222,
-                    'last_pass': 221
+                    'last_pass': 221,
+                    'base_test_name': 'Unittest3.Subtest2'
                 }
             }
         }
     }
 
     expected_step_log_data = {
         223: ('{"Unittest2.Subtest1": "RVJST1I6eF90ZXN0LmNjOjEyMzRcbmEvYi91Mn'
               'MxLmNjOjU2NzogRmFpbHVyZVxuRVJST1I6WzJdOiAyNTk0NzM1MDAwIGJvZ28tb'
               'Wljcm9zZWNvbmRzXG5FUlJPUjp4X3Rlc3QuY2M6MTIzNAphL2IvdTJzMS5jYzo1'
               'Njc6IEZhaWx1cmUK", '
@@ skipping 60 matching lines @@
     cases = {
         failure_type.UNKNOWN: [],
         failure_type.COMPILE: ['compile', 'slave_steps'],
         failure_type.TEST: ['browser_tests'],
     }
     for expected_type, failed_steps in cases.iteritems():
       build_info = BuildInfo('m', 'b', 123)
       build_info.failed_steps = failed_steps
       self.assertEqual(
           expected_type, DetectFirstFailurePipeline._GetFailureType(build_info))
+
+  def testRemoveAnyPrefixes(self):
+    test_samples = ['test1', 'PRE_t', 'TestSuite1.Test1',
+                    'TestSuite1.PRE_Test1', 'TestSuite1.PRE_PRE_Test1',
+                    'PRE_TestSuite1.Test1']
+    expected_base_tests = ['test1', 'PRE_t', 'TestSuite1.Test1',

[stgao, 2016/07/12 17:47:50]

How about a map from original test to base test?

[chanli, 2016/07/12 20:04:52]

Done.

+                           'TestSuite1.Test1', 'TestSuite1.Test1',
+                           'PRE_TestSuite1.Test1']
+
+    base_tests = [detect_first_failure_pipeline._RemoveAnyPrefixes(test)
+                  for test in test_samples]
+    print base_tests
+    self.assertEqual(base_tests, expected_base_tests)