Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(671)

Unified Diff: third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js

Issue 2139043002: DevTools: show alternate title onexpand of object in console (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Reuse dump() in tests Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
diff --git a/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js b/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
index 6be490432683780e6dd09788a75fc1225206ad2c..551cda47faf9e526a3ec2991f6e6038ff51ebc70 100644
--- a/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
+++ b/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
@@ -415,25 +415,10 @@ WebInspector.ConsoleViewMessage.prototype = {
}
}
- var section = this._buildExpandableObjectSection(obj, titleElement);
- elem.appendChild(section.element);
- },
-
- /**
- * @param {!WebInspector.RemoteObject} obj
- * @param {!Element} titleElement
- * @return {!WebInspector.ObjectPropertiesSection}
- */
- _buildExpandableObjectSection: function(obj, titleElement)
- {
- var note = titleElement.createChild("span", "object-state-note");
- note.classList.add("info-note");
- note.title = WebInspector.UIString("Object value at left was snapshotted when logged, value below was evaluated just now.");
-
var section = new WebInspector.ObjectPropertiesSection(obj, titleElement, this._linkifier);
section.element.classList.add("console-view-object-properties-section");
section.enableContextMenu();
- return section;
+ elem.appendChild(section.element);
},
/**
@@ -699,7 +684,9 @@ WebInspector.ConsoleViewMessage.prototype = {
titleElement.createTextChild("]");
- var section = this._buildExpandableObjectSection(array, titleElement);
+ var section = new WebInspector.ObjectPropertiesSection(array, titleElement, this._linkifier);
+ section.element.classList.add("console-view-object-properties-section");
+ section.enableContextMenu();
elem.appendChild(section.element);
},

Powered by Google App Engine
This is Rietveld 408576698