Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/components/ObjectPopoverHelper.js

Issue 2139043002: DevTools: show alternate title onexpand of object in console (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: DevTools: show alternate title onexpand of object in console Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 141 matching lines...) Expand 10 before | Expand all | Expand 10 after
152 } 152 }
153 153
154 if (result.customPreview()) { 154 if (result.customPreview()) {
155 var customPreviewComponent = new WebInspector.CustomPreviewC omponent(result); 155 var customPreviewComponent = new WebInspector.CustomPreviewC omponent(result);
156 customPreviewComponent.expandIfPossible(); 156 customPreviewComponent.expandIfPossible();
157 popoverContentElement = customPreviewComponent.element; 157 popoverContentElement = customPreviewComponent.element;
158 } else { 158 } else {
159 popoverContentElement = createElement("div"); 159 popoverContentElement = createElement("div");
160 this._titleElement = popoverContentElement.createChild("div" , "monospace"); 160 this._titleElement = popoverContentElement.createChild("div" , "monospace");
161 this._titleElement.createChild("span", "source-frame-popover -title").textContent = description; 161 this._titleElement.createChild("span", "source-frame-popover -title").textContent = description;
162 var section = new WebInspector.ObjectPropertiesSection(resul t, "", this._lazyLinkifier()); 162 var section = new WebInspector.ObjectPropertiesSection(resul t, "", null, this._lazyLinkifier());
163 section.element.classList.add("source-frame-popover-tree"); 163 section.element.classList.add("source-frame-popover-tree");
164 section.titleLessMode(); 164 section.titleLessMode();
165 popoverContentElement.appendChild(section.element); 165 popoverContentElement.appendChild(section.element);
166 } 166 }
167 var popoverWidth = 300; 167 var popoverWidth = 300;
168 var popoverHeight = 250; 168 var popoverHeight = 250;
169 popover.showForAnchor(popoverContentElement, anchorElement, popo verWidth, popoverHeight); 169 popover.showForAnchor(popoverContentElement, anchorElement, popo verWidth, popoverHeight);
170 } 170 }
171 } 171 }
172 this._queryObject(element, didQueryObject.bind(this), this._popoverObjec tGroup); 172 this._queryObject(element, didQueryObject.bind(this), this._popoverObjec tGroup);
(...skipping 22 matching lines...) Expand all
195 */ 195 */
196 _lazyLinkifier: function() 196 _lazyLinkifier: function()
197 { 197 {
198 if (!this._linkifier) 198 if (!this._linkifier)
199 this._linkifier = new WebInspector.Linkifier(); 199 this._linkifier = new WebInspector.Linkifier();
200 return this._linkifier; 200 return this._linkifier;
201 }, 201 },
202 202
203 __proto__: WebInspector.PopoverHelper.prototype 203 __proto__: WebInspector.PopoverHelper.prototype
204 } 204 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698