Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/sources/WatchExpressionsSidebarPane.js

Issue 2139043002: DevTools: show alternate title onexpand of object in console (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) IBM Corp. 2009 All rights reserved. 2 * Copyright (C) IBM Corp. 2009 All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 349 matching lines...) Expand 10 before | Expand all | Expand 10 after
360 this._valueElement = WebInspector.ObjectPropertiesSection.createValu eElementWithCustomSupport(result, wasThrown, titleElement, this._linkifier); 360 this._valueElement = WebInspector.ObjectPropertiesSection.createValu eElementWithCustomSupport(result, wasThrown, titleElement, this._linkifier);
361 } 361 }
362 var separatorElement = createElementWithClass("span", "watch-expressions -separator"); 362 var separatorElement = createElementWithClass("span", "watch-expressions -separator");
363 separatorElement.textContent = ": "; 363 separatorElement.textContent = ": ";
364 titleElement.appendChildren(this._nameElement, separatorElement, this._v alueElement); 364 titleElement.appendChildren(this._nameElement, separatorElement, this._v alueElement);
365 365
366 this._element.removeChildren(); 366 this._element.removeChildren();
367 this._objectPropertiesSection = null; 367 this._objectPropertiesSection = null;
368 if (!wasThrown && result && result.hasChildren && !result.customPreview( )) { 368 if (!wasThrown && result && result.hasChildren && !result.customPreview( )) {
369 headerElement.classList.add("watch-expression-object-header"); 369 headerElement.classList.add("watch-expression-object-header");
370 this._objectPropertiesSection = new WebInspector.ObjectPropertiesSec tion(result, headerElement, this._linkifier); 370 this._objectPropertiesSection = new WebInspector.ObjectPropertiesSec tion(result, headerElement, null, this._linkifier);
371 this._objectPresentationElement = this._objectPropertiesSection.elem ent; 371 this._objectPresentationElement = this._objectPropertiesSection.elem ent;
372 this._expandController.watchSection(/** @type {string} */ (this._exp ression), this._objectPropertiesSection); 372 this._expandController.watchSection(/** @type {string} */ (this._exp ression), this._objectPropertiesSection);
373 var objectTreeElement = this._objectPropertiesSection.objectTreeElem ent(); 373 var objectTreeElement = this._objectPropertiesSection.objectTreeElem ent();
374 objectTreeElement.toggleOnClick = false; 374 objectTreeElement.toggleOnClick = false;
375 objectTreeElement.listItemElement.addEventListener("click", this._on SectionClick.bind(this), false); 375 objectTreeElement.listItemElement.addEventListener("click", this._on SectionClick.bind(this), false);
376 objectTreeElement.listItemElement.addEventListener("dblclick", this. _dblClickOnWatchExpression.bind(this)); 376 objectTreeElement.listItemElement.addEventListener("dblclick", this. _dblClickOnWatchExpression.bind(this));
377 } else { 377 } else {
378 this._objectPresentationElement = headerElement; 378 this._objectPresentationElement = headerElement;
379 this._objectPresentationElement.addEventListener("dblclick", this._d blClickOnWatchExpression.bind(this)); 379 this._objectPresentationElement.addEventListener("dblclick", this._d blClickOnWatchExpression.bind(this));
380 } 380 }
(...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after
436 contextMenu.appendApplicableItems(this._result); 436 contextMenu.appendApplicableItems(this._result);
437 }, 437 },
438 438
439 _copyValueButtonClicked: function() 439 _copyValueButtonClicked: function()
440 { 440 {
441 InspectorFrontendHost.copyText(this._valueElement.textContent); 441 InspectorFrontendHost.copyText(this._valueElement.textContent);
442 }, 442 },
443 443
444 __proto__: WebInspector.Object.prototype 444 __proto__: WebInspector.Object.prototype
445 } 445 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698