Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/sources/ScopeChainSidebarPane.js

Issue 2139043002: DevTools: show alternate title onexpand of object in console (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All Rights Reserved. 2 * Copyright (C) 2008 Apple Inc. All Rights Reserved.
3 * Copyright (C) 2011 Google Inc. All rights reserved. 3 * Copyright (C) 2011 Google Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 104 matching lines...) Expand 10 before | Expand all | Expand 10 after
115 } 115 }
116 116
117 var subtitle = scope.description(); 117 var subtitle = scope.description();
118 if (!title || title === subtitle) 118 if (!title || title === subtitle)
119 subtitle = undefined; 119 subtitle = undefined;
120 120
121 var titleElement = createElementWithClass("div", "scope-chain-sideba r-pane-section-header"); 121 var titleElement = createElementWithClass("div", "scope-chain-sideba r-pane-section-header");
122 titleElement.createChild("div", "scope-chain-sidebar-pane-section-su btitle").textContent = subtitle; 122 titleElement.createChild("div", "scope-chain-sidebar-pane-section-su btitle").textContent = subtitle;
123 titleElement.createChild("div", "scope-chain-sidebar-pane-section-ti tle").textContent = title; 123 titleElement.createChild("div", "scope-chain-sidebar-pane-section-ti tle").textContent = title;
124 124
125 var section = new WebInspector.ObjectPropertiesSection(WebInspector. SourceMapNamesResolver.resolveScopeInObject(scope), titleElement, this._linkifie r, emptyPlaceholder, true, extraProperties); 125 var section = new WebInspector.ObjectPropertiesSection(WebInspector. SourceMapNamesResolver.resolveScopeInObject(scope), titleElement, null, this._li nkifier, emptyPlaceholder, true, extraProperties);
126 this._expandController.watchSection(title + (subtitle ? ":" + subtit le : ""), section); 126 this._expandController.watchSection(title + (subtitle ? ":" + subtit le : ""), section);
127 127
128 if (scope.type() === DebuggerAgent.ScopeType.Global) 128 if (scope.type() === DebuggerAgent.ScopeType.Global)
129 section.objectTreeElement().collapse(); 129 section.objectTreeElement().collapse();
130 else if (!foundLocalScope || scope.type() === DebuggerAgent.ScopeTyp e.Local) 130 else if (!foundLocalScope || scope.type() === DebuggerAgent.ScopeTyp e.Local)
131 section.objectTreeElement().expand(); 131 section.objectTreeElement().expand();
132 132
133 section.element.classList.add("scope-chain-sidebar-pane-section"); 133 section.element.classList.add("scope-chain-sidebar-pane-section");
134 this.element.appendChild(section.element); 134 this.element.appendChild(section.element);
135 } 135 }
136 this._sidebarPaneUpdatedForTest(); 136 this._sidebarPaneUpdatedForTest();
137 }, 137 },
138 138
139 _sidebarPaneUpdatedForTest: function() { }, 139 _sidebarPaneUpdatedForTest: function() { },
140 140
141 __proto__: WebInspector.SidebarPane.prototype 141 __proto__: WebInspector.SidebarPane.prototype
142 } 142 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698