chrome/browser/android/webapps/add_to_homescreen_dialog_helper.cc - Issue 2138973002: Initial CL for talking to the WebAPK server to generate WebAPK

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/webapps/add_to_homescreen_dialog_helper.cc

Issue 2138973002: Initial CL for talking to the WebAPK server to generate WebAPK (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Merge branch 'master' into webapk_builder_impl2 Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/android/webapk/webapk_builder.cc ('K') | « chrome/browser/android/webapps/add_to_homescreen_dialog_helper.h ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/webapps/add_to_homescreen_dialog_helper.cc

diff --git a/chrome/browser/android/webapps/add_to_homescreen_dialog_helper.cc b/chrome/browser/android/webapps/add_to_homescreen_dialog_helper.cc

index ba6732f42240274e61db5447ba35c5c9549c86bc..fb6d01471e36d99d16e57035d6d24c8c24fe6e60 100644

--- a/chrome/browser/android/webapps/add_to_homescreen_dialog_helper.cc

+++ b/chrome/browser/android/webapps/add_to_homescreen_dialog_helper.cc

@@ -44,7 +44,8 @@ AddToHomescreenDialogHelper::AddToHomescreenDialogHelper(

ShortcutHelper::GetMinimumHomescreenIconSizeInDp(),

ShortcutHelper::GetIdealSplashImageSizeInDp(),

ShortcutHelper::GetMinimumSplashImageSizeInDp(),

- this)) {

+ this)),

+ browser_context_(web_contents->GetBrowserContext()) {

java_ref_.Reset(env, obj);

}

@@ -122,8 +123,8 @@ void AddToHomescreenDialogHelper::AddShortcut(const ShortcutInfo& info,

const std::string& uid = base::GenerateGUID();

content::BrowserThread::PostTask(

content::BrowserThread::IO, FROM_HERE,

- base::Bind(&ShortcutHelper::AddToLauncherInBackgroundWithSkBitmap, info,

- uid, icon,

+ base::Bind(&ShortcutHelper::AddToLauncherInBackgroundWithSkBitmap,

+ browser_context_, info, uid, icon,

data_fetcher_->FetchSplashScreenImageCallback(uid)));

}