Chromium Code Reviews| Index: chrome/browser/android/shortcut_helper.h |
| diff --git a/chrome/browser/android/shortcut_helper.h b/chrome/browser/android/shortcut_helper.h |
| index e552adec6da226fcefda43356de1a554748f8c84..389feadbe6a5747f3038f3503ac444c10f018660 100644 |
| --- a/chrome/browser/android/shortcut_helper.h |
| +++ b/chrome/browser/android/shortcut_helper.h |
| @@ -13,6 +13,7 @@ |
| #include "third_party/skia/include/core/SkBitmap.h" |
| namespace content { |
| +class BrowserContext; |
| class WebContents; |
| } // namespace content |
| @@ -26,6 +27,7 @@ class ShortcutHelper { |
| // Adds a shortcut to the launcher using a SkBitmap. |
| // Must not be called on the UI thread. |
| static void AddShortcutInBackgroundWithSkBitmap( |
| + content::BrowserContext* browser_context, |
| const ShortcutInfo& info, |
| const std::string& webapp_id, |
| const SkBitmap& icon_bitmap, |
| @@ -34,8 +36,8 @@ class ShortcutHelper { |
| // Installs WebAPK and adds shortcut to the launcher. |
| // Must not be called on the UI thread. |
| static void AddWebApkInBackgroundWithSkBitmap( |
| + content::BrowserContext* browser_context, |
| const ShortcutInfo& info, |
| - const std::string& webapp_id, |
| const SkBitmap& icon_bitmap); |
| // Adds a shortcut which opens in a fullscreen window to the launcher. |
| @@ -56,6 +58,16 @@ class ShortcutHelper { |
| const ShortcutInfo& info, |
| const SkBitmap& icon_bitmap); |
| + // Called after either: |
| + // - A request to download and install the WebAPK has been sent to |
| + // the Google Play server. |
|
Yaron
2016/07/13 00:24:01
this is an implementation detail
pkotwicz
2016/07/13 02:15:30
How do you suggest that I improve this comment?
|
| + // OR |
| + // - WebAPK creation process fails. |
| + // |success| indicates whether the request was sent to the Google Play server. |
| + // A "true" value of |success| does not guarantee that the WebAPK will be |
| + // successfully downloaded from the WebAPK server. |
| + static void OnBuiltWebApk(bool success); |
| + |
| // Returns the ideal size for an icon representing a web app. |
| static int GetIdealHomescreenIconSizeInDp(); |