Initial CL for talking to the WebAPK server to generate WebAPK

content/public/common/manifest_util.cc

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "content/public/common/manifest_util.h"
+
+#include "base/strings/string_util.h"

[mlamouri (slow - plz ping), 2016/08/04 13:04:26]

Why do you need this?

+
+namespace content {
+
+std::string WebDisplayModeToString(blink::WebDisplayMode display) {
+  switch (display) {
+    case blink::WebDisplayModeUndefined:
+      return "";
+    case blink::WebDisplayModeBrowser:
+      return "browser";
+    case blink::WebDisplayModeMinimalUi:
+      return "minimal-ui";
+    case blink::WebDisplayModeStandalone:
+      return "standalone";
+    case blink::WebDisplayModeFullscreen:
+      return "fullscreen";
+  }
+}
+
+blink::WebDisplayMode WebDisplayModeFromString(const std::string& display) {
+  if (display == "browser")

[mlamouri (slow - plz ping), 2016/08/04 13:04:26]

Maybe add a DCHECK() enforcing that |display| is lower case?

[pkotwicz, 2016/08/04 15:42:45]

I have changed this function to be case insensitive

+    return blink::WebDisplayModeBrowser;
+  else if (display == "minimal-ui")
+    return blink::WebDisplayModeMinimalUi;
+  else if (display == "standalone")
+    return blink::WebDisplayModeStandalone;
+  else if (display == "fullscreen")
+    return blink::WebDisplayModeFullscreen;
+  else

[mlamouri (slow - plz ping), 2016/08/04 13:04:26]

scratch the `else` here

+    return blink::WebDisplayModeUndefined;
+}
+
+std::string WebScreenOrientationLockTypeToString(
+    blink::WebScreenOrientationLockType orientation) {
+  switch (orientation) {
+    case blink::WebScreenOrientationLockDefault:
+      return "";
+    case blink::WebScreenOrientationLockPortraitPrimary:
+      return "portrait-primary";
+    case blink::WebScreenOrientationLockPortraitSecondary:
+      return "portrait-secondary";
+    case blink::WebScreenOrientationLockLandscapePrimary:
+      return "landscape-primary";
+    case blink::WebScreenOrientationLockLandscapeSecondary:
+      return "landscape-secondary";
+    case blink::WebScreenOrientationLockAny:
+      return "any";
+    case blink::WebScreenOrientationLockLandscape:
+      return "landscape";
+    case blink::WebScreenOrientationLockPortrait:
+      return "portrait";
+    case blink::WebScreenOrientationLockNatural:
+      return "natural";
+  }
+}
+
+blink::WebScreenOrientationLockType
+WebScreenOrientationLockTypeFromString(const std::string& orientation) {
+  if (orientation == "portrait-primary")

[mlamouri (slow - plz ping), 2016/08/04 13:04:26]

As above, maybe add a DCHECK?

[pkotwicz, 2016/08/04 15:42:45]

I have changed this function to be case insensitive

+    return blink::WebScreenOrientationLockPortraitPrimary;
+  else if (orientation == "portrait-secondary")
+    return blink::WebScreenOrientationLockPortraitSecondary;
+  else if (orientation == "landscape-primary")
+    return blink::WebScreenOrientationLockLandscapePrimary;
+  else if (orientation == "landscape-secondary")
+    return blink::WebScreenOrientationLockLandscapeSecondary;
+  else if (orientation == "any")
+    return blink::WebScreenOrientationLockAny;
+  else if (orientation == "landscape")
+    return blink::WebScreenOrientationLockLandscape;
+  else if (orientation == "portrait")
+    return blink::WebScreenOrientationLockPortrait;
+  else if (orientation == "natural")
+    return blink::WebScreenOrientationLockNatural;
+  return blink::WebScreenOrientationLockDefault;
+}
+
+}  // namespace content