chrome/browser/android/webapk/DEPS - Issue 2138973002: Initial CL for talking to the WebAPK server to generate WebAPK

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/android/webapk/DEPS

Issue 2138973002: Initial CL for talking to the WebAPK server to generate WebAPK (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/android/shortcut_helper.cc ('K') | « chrome/browser/android/webapk/BUILD.gn ('k') | chrome/browser/android/webapk/webapk.proto » ('j') | chrome/browser/android/webapk/webapk.proto » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 specific_include_rules = {

	2 "webapk_builder_unittest\.cc": [

	3 "+content/renderer/manifest/manifest_parser.h",
	Yaron 2016/07/13 00:24:01 does this need to be moved to content/public or ar does this need to be moved to content/public or are there examples of unittests which reach into content (I'm unsure) Yaron 2016/07/19 17:31:13 bump. looking at the test, I don't think it's tes Show quoted text On 2016/07/13 00:24:01, Yaron wrote: > does this need to be moved to content/public or are there examples of unittests > which reach into content (I'm unsure) bump. looking at the test, I don't think it's testing the right thing. content::ManifestParser isn't even going to really parse the manifest (the server will) and is orthogonal to your functionality. pkotwicz 2016/07/20 05:13:41 You are right using content/renderer/manifest/mani You are right using content/renderer/manifest/manifest_parser.h in the unit test is wrong. The spirit of the test is correct. The server API is defined in terms of the W3C Web Manifest spec. Testing WebApkBuilder::OrientationToString() against ManifestParser is valid. Perhaps I should introduce ManifestUtil in content/public/manifest_util.h which converts between blink::WebScreenOrientationLockType <-> std::string. What do you think? Yaron 2016/07/20 13:13:50 That would be fine with me. Another option would b Show quoted text On 2016/07/20 05:13:41, pkotwicz wrote: > You are right using content/renderer/manifest/manifest_parser.h in the unit test > is wrong. The spirit of the test is correct. The server API is defined in terms > of the W3C Web Manifest spec. Testing WebApkBuilder::OrientationToString() > against ManifestParser is valid. Perhaps I should introduce ManifestUtil in > content/public/manifest_util.h which converts between > blink::WebScreenOrientationLockType <-> std::string. What do you think? That would be fine with me. Another option would be to move the enum conversion code down to content (with a public accessor) and test it there. It's nice in that it localizes it with the relevant code as opposed to the mapping being in a consumer and it's not dependent on our specific feature.
	4 ]

	5 }

	6

OLD	NEW