tests/MatrixTest.cpp - Issue 2138943002: Change mapRectScaleTranslate to pass args/ret by value

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/MatrixTest.cpp

Issue 2138943002: Change mapRectScaleTranslate to pass args/ret by value (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tests/MatrixTest.cpp

diff --git a/tests/MatrixTest.cpp b/tests/MatrixTest.cpp

index 414aab2f9a85b77e3d4118bb7b97859486f2c053..6cba60421669d16807cc97930508ce1a23450607 100644

--- a/tests/MatrixTest.cpp

+++ b/tests/MatrixTest.cpp

@@ -984,7 +984,7 @@ DEF_TEST(Matrix_maprects, r) {

mat.mapPoints((SkPoint*)&dst[0].fLeft, (SkPoint*)&src.fLeft, 2);

dst[0].sort();

mat.mapRect(&dst[1], src);

- mat.mapRectScaleTranslate(&dst[2], src);

+ dst[2] = mat.mapRectScaleTranslate(src);

REPORTER_ASSERT(r, dst[0] == dst[1]);

REPORTER_ASSERT(r, dst[0] == dst[2]);

« no previous file with comments | « src/utils/SkDeferredCanvas.cpp ('k') | no next file » | no next file with comments »