Reformat example LayoutTestResults in rebaseline_unittest.

Reformat example LayoutTestResults in rebaseline_unittest.

This CL just converts expressions of the form

   LayoutTestResults.results_from_string("""ADD_RESULTS({
"tests": {...}
});"""

to expressions of the form:

   data = LayoutTestResults({"tests": {...}})

The use of literal strings with ADD_RESULTS just makes the tests harder
to read without adding benefit.

This is related to http://crrev.com/2129323002, and the end purpose is
to make it easier to change the code and tests to enable
http://crrev.com/2118513002 to work.

Committed: https://crrev.com/249277aa25ed5556d9167724527219c66deecc1e
Cr-Commit-Position: refs/heads/master@{#404720}

[qyearsley, 2016-07-11 17:20:57]

qyearsley@chromium.org changed reviewers:
+ dpranke@chromium.org, wkorman@chromium.org

[qyearsley, 2016-07-11 17:25:22]

https://codereview.chromium.org/2138913002/diff/1/third_party/WebKit/Tools/Sc...
File
third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py
(left):

https://codereview.chromium.org/2138913002/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py:832:
print self.tool.executive.calls
Print statement accidentally left in in http://crrev.com/2069743002

https://codereview.chromium.org/2138913002/diff/1/third_party/WebKit/Tools/Sc...
File
third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py
(right):

https://codereview.chromium.org/2138913002/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py:1055:
# Have prototype-chocolate only fail on "MOCK Mac10.11".
Note, I think this may have been a typo in the CL that last updated it
(http://crrev.com/1733163002).

[wkorman, 2016-07-11 17:58:43]

lgtm

I think there's a typo in your CL description, text 'Apply difference' not
needed?

[qyearsley, 2016-07-11 18:05:04]

Description was changed from

==========
Reformat example LayoutTestResults in rebaseline_unittest.

This CL just converts expressions of the form

   LayoutTestResults.results_from_string("""ADD_RESULTS({
"tests": {...}
});"""

to expressions of the form:

   data = LayoutTestResults({"tests": {...}})

The use of literal strings with ADD_RESULTS just makes the tests harder
to read without adding benefit.
Apply difference

This is related to http://crrev.com/2129323002, and the end purpose is
to make it easier to change the code and tests to enable
http://crrev.com/2118513002 to work.
==========

to

==========
Reformat example LayoutTestResults in rebaseline_unittest.

This CL just converts expressions of the form

   LayoutTestResults.results_from_string("""ADD_RESULTS({
"tests": {...}
});"""

to expressions of the form:

   data = LayoutTestResults({"tests": {...}})

The use of literal strings with ADD_RESULTS just makes the tests harder
to read without adding benefit.

This is related to http://crrev.com/2129323002, and the end purpose is
to make it easier to change the code and tests to enable
http://crrev.com/2118513002 to work.
==========

[qyearsley, 2016-07-11 18:05:44]

On 2016/07/11 at 17:58:43, wkorman wrote:
> lgtm
> 
> I think there's a typo in your CL description, text 'Apply difference' not
needed?

Ah! Not sure where that came from. Now updated. Thanks for taking a look :-)

[qyearsley, 2016-07-11 18:05:46]

The CQ bit was checked by qyearsley@chromium.org

[commit-bot: I haz the power, 2016-07-11 18:06:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-11 20:17:30]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-11 20:17:42]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-11 20:19:11]

Description was changed from

==========
Reformat example LayoutTestResults in rebaseline_unittest.

This CL just converts expressions of the form

   LayoutTestResults.results_from_string("""ADD_RESULTS({
"tests": {...}
});"""

to expressions of the form:

   data = LayoutTestResults({"tests": {...}})

The use of literal strings with ADD_RESULTS just makes the tests harder
to read without adding benefit.

This is related to http://crrev.com/2129323002, and the end purpose is
to make it easier to change the code and tests to enable
http://crrev.com/2118513002 to work.
==========

to

==========
Reformat example LayoutTestResults in rebaseline_unittest.

This CL just converts expressions of the form

   LayoutTestResults.results_from_string("""ADD_RESULTS({
"tests": {...}
});"""

to expressions of the form:

   data = LayoutTestResults({"tests": {...}})

The use of literal strings with ADD_RESULTS just makes the tests harder
to read without adding benefit.

This is related to http://crrev.com/2129323002, and the end purpose is
to make it easier to change the code and tests to enable
http://crrev.com/2118513002 to work.

Committed: https://crrev.com/249277aa25ed5556d9167724527219c66deecc1e
Cr-Commit-Position: refs/heads/master@{#404720}
==========

[commit-bot: I haz the power, 2016-07-11 20:19:12]

Patchset 1 (id:??) landed as
https://crrev.com/249277aa25ed5556d9167724527219c66deecc1e
Cr-Commit-Position: refs/heads/master@{#404720}

[Dirk Pranke, 2016-08-09 03:49:13]

lgtm (very belatedly).