Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 2138903002: tracing v2: refactor fake_scattered_buffer class for tests (Closed)

Created:
4 years, 5 months ago by Primiano Tucci (use gerrit)
Modified:
4 years, 5 months ago
Reviewers:
petrcermak
CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

tracing v2: refactor fake_scattered_buffer class for tests Just a refactoring of test classes. This extracts a FakeScatteredBuffer class out of the existing unittest. This class will be reused by other unittests added in upcoming CLs. BUG=608719 TEST=components_unittests --gtest_filter=ScatteredStreamWriterTest.* Committed: https://crrev.com/2de26b9da11e36dc1be40af96f5fb3e1c5fbd8f1 Cr-Commit-Position: refs/heads/master@{#405119}

Patch Set 1 #

Total comments: 2

Patch Set 2 : petr review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -30 lines) Patch
M components/components_tests.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M components/tracing/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/tracing/core/scattered_stream_writer_unittest.cc View 3 chunks +12 lines, -30 lines 0 comments Download
A components/tracing/test/fake_scattered_buffer.h View 1 chunk +47 lines, -0 lines 0 comments Download
A components/tracing/test/fake_scattered_buffer.cc View 1 1 chunk +48 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (10 generated)
Primiano Tucci (use gerrit)
PTAL, small refactor
4 years, 5 months ago (2016-07-11 17:05:29 UTC) #2
petrcermak
LGTM with one comment and s/by upcoming CLs/added in upcoming CLs/. Thanks, Petr https://codereview.chromium.org/2138903002/diff/1/components/tracing/test/fake_scattered_buffer.cc File ...
4 years, 5 months ago (2016-07-12 10:29:44 UTC) #3
Primiano Tucci (use gerrit)
thanks https://codereview.chromium.org/2138903002/diff/1/components/tracing/test/fake_scattered_buffer.cc File components/tracing/test/fake_scattered_buffer.cc (right): https://codereview.chromium.org/2138903002/diff/1/components/tracing/test/fake_scattered_buffer.cc#newcode36 components/tracing/test/fake_scattered_buffer.cc:36: DCHECK_LT(chunk_idx, chunks_.size()); On 2016/07/12 10:29:44, petrcermak wrote: > ...
4 years, 5 months ago (2016-07-12 11:04:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2138903002/20001
4 years, 5 months ago (2016-07-12 11:05:07 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/191196)
4 years, 5 months ago (2016-07-12 13:06:44 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2138903002/20001
4 years, 5 months ago (2016-07-12 17:25:32 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/191497)
4 years, 5 months ago (2016-07-12 22:38:46 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2138903002/20001
4 years, 5 months ago (2016-07-13 09:54:45 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-13 11:00:52 UTC) #18
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-13 11:00:57 UTC) #19
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 11:03:37 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2de26b9da11e36dc1be40af96f5fb3e1c5fbd8f1
Cr-Commit-Position: refs/heads/master@{#405119}

Powered by Google App Engine
This is Rietveld 408576698