tracing v2: refactor fake_scattered_buffer class for tests

tracing v2: refactor fake_scattered_buffer class for tests

Just a refactoring of test classes. This extracts a
FakeScatteredBuffer class out of the existing unittest. This
class will be reused by other unittests added in
upcoming CLs.

BUG=608719
TEST=components_unittests --gtest_filter=ScatteredStreamWriterTest.*

Committed: https://crrev.com/2de26b9da11e36dc1be40af96f5fb3e1c5fbd8f1
Cr-Commit-Position: refs/heads/master@{#405119}

[Primiano Tucci (use gerrit), 2016-07-11 17:05:29]

primiano@chromium.org changed reviewers:
+ petrcermak@chromium.org

[Primiano Tucci (use gerrit), 2016-07-11 17:05:29]

PTAL, small refactor

[petrcermak, 2016-07-12 10:29:44]

LGTM with one comment and s/by upcoming CLs/added in upcoming CLs/.

Thanks,
Petr

https://codereview.chromium.org/2138903002/diff/1/components/tracing/test/fak...
File components/tracing/test/fake_scattered_buffer.cc (right):

https://codereview.chromium.org/2138903002/diff/1/components/tracing/test/fak...
components/tracing/test/fake_scattered_buffer.cc:36: DCHECK_LT(chunk_idx,
chunks_.size());
Given that this will only be used in tests, wouldn't it make sense to use a
check that will run even when DCHECK is disabled?

[Primiano Tucci (use gerrit), 2016-07-12 10:53:07]

Description was changed from

==========
tracing v2: refactor fake_scattered_buffer class for tests

Just a refactoring of test classes. This extracts a
FakeScatteredBuffer class out of the existing unittest. This
class will be reused by other unittests by upcoming CLs.

BUG=608719
TEST=components_unittests --gtest_filter=ScatteredStreamWriterTest.*
==========

to

==========
tracing v2: refactor fake_scattered_buffer class for tests

Just a refactoring of test classes. This extracts a
FakeScatteredBuffer class out of the existing unittest. This
class will be reused by other unittests added in
upcoming CLs.

BUG=608719
TEST=components_unittests --gtest_filter=ScatteredStreamWriterTest.*
==========

[Primiano Tucci (use gerrit), 2016-07-12 11:04:26]

thanks

https://codereview.chromium.org/2138903002/diff/1/components/tracing/test/fak...
File components/tracing/test/fake_scattered_buffer.cc (right):

https://codereview.chromium.org/2138903002/diff/1/components/tracing/test/fak...
components/tracing/test/fake_scattered_buffer.cc:36: DCHECK_LT(chunk_idx,
chunks_.size());
On 2016/07/12 10:29:44, petrcermak wrote:
> Given that this will only be used in tests, wouldn't it make sense to use a
> check that will run even when DCHECK is disabled?

all bots these days run with DCHECK_ALWAYS_ON (so dchecks are enabled even for
release).
But your comment made me realize that this is not really a dcheck. If we hit
this path this is not a problem with the fake buffer itself, it's the text
fixture doing something wrong, and this should be an expectation failure. (I
can't use assert, they are valid only in TEST_F functions)

[Primiano Tucci (use gerrit), 2016-07-12 11:04:44]

The CQ bit was checked by primiano@chromium.org

[Primiano Tucci (use gerrit), 2016-07-12 11:04:44]

The patchset sent to the CQ was uploaded after l-g-t-m from
petrcermak@chromium.org
Link to the patchset: https://codereview.chromium.org/2138903002/#ps20001
(title: "petr review")

[commit-bot: I haz the power, 2016-07-12 11:05:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-12 13:06:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-12 13:06:44]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Primiano Tucci (use gerrit), 2016-07-12 17:24:14]

The CQ bit was checked by primiano@chromium.org

[commit-bot: I haz the power, 2016-07-12 17:25:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-12 22:38:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-12 22:38:46]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Primiano Tucci (use gerrit), 2016-07-13 09:54:24]

The CQ bit was checked by primiano@chromium.org

[commit-bot: I haz the power, 2016-07-13 09:54:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 11:00:51]

Description was changed from

==========
tracing v2: refactor fake_scattered_buffer class for tests

Just a refactoring of test classes. This extracts a
FakeScatteredBuffer class out of the existing unittest. This
class will be reused by other unittests added in
upcoming CLs.

BUG=608719
TEST=components_unittests --gtest_filter=ScatteredStreamWriterTest.*
==========

to

==========
tracing v2: refactor fake_scattered_buffer class for tests

Just a refactoring of test classes. This extracts a
FakeScatteredBuffer class out of the existing unittest. This
class will be reused by other unittests added in
upcoming CLs.

BUG=608719
TEST=components_unittests --gtest_filter=ScatteredStreamWriterTest.*
==========

[commit-bot: I haz the power, 2016-07-13 11:00:52]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-13 11:00:57]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-13 11:03:36]

Description was changed from

==========
tracing v2: refactor fake_scattered_buffer class for tests

Just a refactoring of test classes. This extracts a
FakeScatteredBuffer class out of the existing unittest. This
class will be reused by other unittests added in
upcoming CLs.

BUG=608719
TEST=components_unittests --gtest_filter=ScatteredStreamWriterTest.*
==========

to

==========
tracing v2: refactor fake_scattered_buffer class for tests

Just a refactoring of test classes. This extracts a
FakeScatteredBuffer class out of the existing unittest. This
class will be reused by other unittests added in
upcoming CLs.

BUG=608719
TEST=components_unittests --gtest_filter=ScatteredStreamWriterTest.*

Committed: https://crrev.com/2de26b9da11e36dc1be40af96f5fb3e1c5fbd8f1
Cr-Commit-Position: refs/heads/master@{#405119}
==========

[commit-bot: I haz the power, 2016-07-13 11:03:37]

Patchset 2 (id:??) landed as
https://crrev.com/2de26b9da11e36dc1be40af96f5fb3e1c5fbd8f1
Cr-Commit-Position: refs/heads/master@{#405119}