Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Unified Diff: telemetry/telemetry/internal/actions/key_event_unittest.py

Issue 2138883002: Fix computation of scroll amount in scroll actions. (Closed) Base URL: https://github.com/catapult-project/catapult.git@master
Patch Set: Address comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: telemetry/telemetry/internal/actions/key_event_unittest.py
diff --git a/telemetry/telemetry/internal/actions/key_event_unittest.py b/telemetry/telemetry/internal/actions/key_event_unittest.py
index b1b43d35ec7e4da3d7c28962e79b676f94fc0f3f..8721847ceccd51015c913e4ea1e2a101c53e7df5 100644
--- a/telemetry/telemetry/internal/actions/key_event_unittest.py
+++ b/telemetry/telemetry/internal/actions/key_event_unittest.py
@@ -5,6 +5,7 @@
import time
from telemetry.internal.actions import key_event
+from telemetry.internal.actions import utils
from telemetry.testing import tab_test_case
@@ -17,7 +18,7 @@ class KeyPressActionTest(tab_test_case.TabTestCase):
@property
def _window_height(self):
- return self._tab.EvaluateJavaScript('window.innerHeight')
+ return self._tab.EvaluateJavaScript('__GestureCommon_GetWindowHeight()')
def _PressKey(self, key):
action = key_event.KeyPressAction(key)
@@ -27,11 +28,12 @@ class KeyPressActionTest(tab_test_case.TabTestCase):
def setUp(self):
tab_test_case.TabTestCase.setUp(self)
self.Navigate('blank.html')
+ utils.InjectJavaScript(self._tab, 'gesture_common.js')
def testPressEndAndHome(self):
# Make page taller than the window so it's scrollable.
- self._tab.ExecuteJavaScript(
- 'document.body.style.height = (3 * window.innerHeight + 1) + "px";')
+ self._tab.ExecuteJavaScript('document.body.style.height ='
+ '(3 * __GestureCommon_GetWindowHeight() + 1) + "px";')
# Check that the browser is currently showing the top of the page and that
# the page has non-trivial height.
« no previous file with comments | « telemetry/telemetry/internal/actions/gesture_common.js ('k') | telemetry/telemetry/internal/actions/load_media.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698