Add tests for the Display operation of the mac notification bridge.

chrome/browser/notifications/notification_platform_bridge_mac.mm

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/notifications/notification_platform_bridge_mac.h"
 
 #include <utility>
 
 #include "base/mac/foundation_util.h"
 #include "base/mac/mac_util.h"
@@ skipping 73 matching lines @@
 // A Cocoa class that represents the delegate of NSUserNotificationCenter and
 // can forward commands to C++.
 @interface NotificationCenterDelegate
     : NSObject<NSUserNotificationCenterDelegate> {
 }
 @end
 
 // /////////////////////////////////////////////////////////////////////////////
 
 NotificationPlatformBridgeMac::NotificationPlatformBridgeMac(
-    NSUserNotificationCenter* notification_center)
+    NSUserNotificationCenter* notification_center) {
+  NotificationPlatformBridgeMac(notification_center, true /* set_delegate */);

[Peter Beverloo, 2016/07/11 17:25:48]

You can define a delegating constructor like:

NotificationPlatformBridgeMac::NotificationPlatformBridgeMac(
    NSUserNotificationCenter* notification_center)
    : NotificationPlatformBridgeMac(notification_center,
                                    true /* set_delegate */) {}

That said, the number of callers for NotificationPlatformBridgeMac is
sufficiently low that it'd be even better to drop the second constructor
altogether, and just always pass the boolean.

[Miguel Garcia, 2016/07/12 16:16:24]

You know I usually go with the flow with regards to following review comments
but in this case I am going to insist on keep the hack private at least :) Now
that we know why it is needed I think I will remove it the minute the dependent
roll happens.

So for now I switched to delegating constructor.

On 2016/07/11 17:25:48, Peter Beverloo wrote:

+}
+
+NotificationPlatformBridgeMac::NotificationPlatformBridgeMac(
+    NSUserNotificationCenter* notification_center,
+    bool set_delegate)
     : delegate_([NotificationCenterDelegate alloc]),
       notification_center_(notification_center) {
-  [notification_center_ setDelegate:delegate_.get()];
+  // Setting up the delegte upsets OCMock.

[Peter Beverloo, 2016/07/11 17:25:48]

delegte -> delegate

Rather than saying that it "upsets OCMock", it would be more valuable to
describe why that is an issue.

[Miguel Garcia, 2016/07/12 16:16:24]

Now that we know why sure :)

+  if (set_delegate)
+    notification_center.delegate = delegate_.get();

[Peter Beverloo, 2016/07/11 17:25:48]

Why did the syntax for the assignment change?

[Miguel Garcia, 2016/07/12 16:16:24]

It was me trying some things to keep OCMock happy, will revert.

 }
 
 NotificationPlatformBridgeMac::~NotificationPlatformBridgeMac() {
   [notification_center_ setDelegate:nil];
 
   // TODO(miguelg) lift this restriction if possible.
   [notification_center_ removeAllDeliveredNotifications];
 }
 
 void NotificationPlatformBridgeMac::Display(
@@ skipping 216 matching lines @@
           notificationOrigin, persistentNotificationId, buttonIndex.intValue));
 }
 
 - (BOOL)userNotificationCenter:(NSUserNotificationCenter*)center
      shouldPresentNotification:(NSUserNotification*)nsNotification {
   // Always display notifications, regardless of whether the app is foreground.
   return YES;
 }
 
 @end