Add tests for the Display operation of the mac notification bridge.

chrome/browser/notifications/notification_platform_bridge_mac.mm

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/notifications/notification_platform_bridge_mac.h"
 
 #include <utility>
 
 #include "base/mac/foundation_util.h"
 #include "base/mac/mac_util.h"
@@ skipping 74 matching lines @@
 // can forward commands to C++.
 @interface NotificationCenterDelegate
     : NSObject<NSUserNotificationCenterDelegate> {
 }
 @end
 
 // /////////////////////////////////////////////////////////////////////////////
 
 NotificationPlatformBridgeMac::NotificationPlatformBridgeMac(
     NSUserNotificationCenter* notification_center)
+    : NotificationPlatformBridgeMac(notification_center,
+                                    true /* set_delegate */) {}

[Nico, 2016/07/12 17:54:38]

please use /*set_delegate=*/true (the spelling you have is ambiguous for false
parameters: Does `false /*do_it*/` mean that do_it is set to false and that it's
not done, or does it mean that the flag is dont_do_it and since it's false we're
about to do_it)?

[Miguel Garcia, 2016/07/13 14:05:16]

Done.

+
+NotificationPlatformBridgeMac::NotificationPlatformBridgeMac(
+    NSUserNotificationCenter* notification_center,
+    bool set_delegate)
     : delegate_([NotificationCenterDelegate alloc]),
       notification_center_(notification_center) {
-  [notification_center_ setDelegate:delegate_.get()];
+  // OCMock does not support dynamic properties yet.
+  // TODO(miguelg): remove once cbug.com/622753 is resolved.
+  if (set_delegate)
+    [notification_center_ setDelegate:delegate_.get()];
 }
 
 NotificationPlatformBridgeMac::~NotificationPlatformBridgeMac() {
   [notification_center_ setDelegate:nil];
 
   // TODO(miguelg) lift this restriction if possible.
   [notification_center_ removeAllDeliveredNotifications];
 }
 
 void NotificationPlatformBridgeMac::Display(
@@ skipping 216 matching lines @@
           notificationOrigin, persistentNotificationId, buttonIndex.intValue));
 }
 
 - (BOOL)userNotificationCenter:(NSUserNotificationCenter*)center
      shouldPresentNotification:(NSUserNotification*)nsNotification {
   // Always display notifications, regardless of whether the app is foreground.
   return YES;
 }
 
 @end