Add tests for the Display operation of the mac notification bridge.

chrome/browser/notifications/notification_platform_bridge_mac.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_NOTIFICATIONS_NOTIFICATION_PLATFORM_BRIDGE_MAC_H_
 #define CHROME_BROWSER_NOTIFICATIONS_NOTIFICATION_PLATFORM_BRIDGE_MAC_H_
 
 #include <set>
 #include <string>
 
 #include "base/compiler_specific.h"
+#include "base/gtest_prod_util.h"
 #include "base/mac/scoped_nsobject.h"
 #include "base/macros.h"
 #include "chrome/browser/notifications/notification_common.h"
 #include "chrome/browser/notifications/notification_platform_bridge.h"
 
 class Notification;
 @class NotificationCenterDelegate;
 @class NSDictionary;
 @class NSUserNotificationCenter;
 class PrefService;
@@ skipping 17 matching lines @@
   bool GetDisplayed(const std::string& profile_id,
                     bool incognito,
                     std::set<std::string>* notifications) const override;
   bool SupportsNotificationCenter() const override;
 
   // Validates contents of the |response| dictionary as received from the system
   // when a notification gets activated.
   static bool VerifyNotificationData(NSDictionary* response) WARN_UNUSED_RESULT;
 
  private:
+  FRIEND_TEST_ALL_PREFIXES(NotificationPlatformBridgeMacTest,

[Robert Sesek, 2016/07/12 17:33:36]

Since this is just to gain access to the private ctor, what I like to do is to
friend class NotificationConversionHelperTest. Then have a helper method on that
friended class, so you can avoid the FRIEND_TEST macros (for when more tests are
added).

But since this is all a hack around the OCMock roll, this is optional.

[Miguel Garcia, 2016/07/13 14:05:16]

Acknowledged.

+                           TestDisplayNoButtons);
+  FRIEND_TEST_ALL_PREFIXES(NotificationPlatformBridgeMacTest,
+                           TestDisplayOneButton);
+  FRIEND_TEST_ALL_PREFIXES(NotificationPlatformBridgeMacTest, TestClose);
+
+  // Used directly in tests.
+  NotificationPlatformBridgeMac(NSUserNotificationCenter* notification_center,
+                                bool set_delegate);
+
   // Cocoa class that receives callbacks from the NSUserNotificationCenter.
   base::scoped_nsobject<NotificationCenterDelegate> delegate_;
 
   // The notification center to use, this can be overriden in tests
   NSUserNotificationCenter* notification_center_;
 
   DISALLOW_COPY_AND_ASSIGN(NotificationPlatformBridgeMac);
 };
 
 #endif  // CHROME_BROWSER_NOTIFICATIONS_NOTIFICATION_PLATFORM_BRIDGE_MAC_H_