Issue 2138843002: 'Import library' fixes should use the same 'addLibraryImports' implementation as the fixes where im…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2138843002: 'Import library' fixes should use the same 'addLibraryImports' implementation as the fixes where im… (Closed)

Created:
4 years, 5 months ago by scheglov

Modified:
4 years, 5 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

'Import library' fixes should use the same 'addLibraryImports' implementation as the fixes where importing is a side effect. Preparation for https://github.com/dart-lang/sdk/issues/26764 R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/d2d8dbff41a70facbf33727d3172f194acf48fc0

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -54 lines)			Patch
	M	pkg/analysis_server/lib/src/services/correction/fix_internal.dart	View		4 chunks	+10 lines, -52 lines	0 comments	Download
	M	pkg/analysis_server/lib/src/services/correction/util.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 4 (1 generated)

scheglov

4 years, 5 months ago (2016-07-11 16:34:03 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
d2d8dbff41a70facbf33727d3172f194acf48fc0 (presubmit successful).