Cleanup CXFA_SimpleParser.

Cleanup CXFA_SimpleParser.

This CL moves the static methods to an anonymous namespace and cleans up various
formatting issues.

Committed: https://pdfium.googlesource.com/pdfium/+/ac14258c429141653f73ca5c1b64ad259ac15804

[dsinclair, 2016-07-11 16:00:55]

dsinclair@chromium.org changed reviewers:
+ thestig@chromium.org, weili@chromium.org

[dsinclair, 2016-07-11 16:00:56]

PTAL.

[Wei Li, 2016-07-11 17:53:38]

lgtm

https://codereview.chromium.org/2138833002/diff/1/xfa/fxfa/parser/cxfa_simple...
File xfa/fxfa/parser/cxfa_simple_parser.cpp (right):

https://codereview.chromium.org/2138833002/diff/1/xfa/fxfa/parser/cxfa_simple...
xfa/fxfa/parser/cxfa_simple_parser.cpp:17: class RichTextNodeVisitor {
Is this used?

https://codereview.chromium.org/2138833002/diff/1/xfa/fxfa/parser/cxfa_simple...
xfa/fxfa/parser/cxfa_simple_parser.cpp:37:
pXMLFakeRoot->GetNodeItem(CFDE_XMLNode::FirstChild);
Nit: no need for |pXMLFakeRoot|

[dsinclair, 2016-07-11 18:55:01]

https://codereview.chromium.org/2138833002/diff/1/xfa/fxfa/parser/cxfa_simple...
File xfa/fxfa/parser/cxfa_simple_parser.cpp (right):

https://codereview.chromium.org/2138833002/diff/1/xfa/fxfa/parser/cxfa_simple...
xfa/fxfa/parser/cxfa_simple_parser.cpp:17: class RichTextNodeVisitor {
On 2016/07/11 17:53:38, Wei Li wrote:
> Is this used?

Nice catch, removed.

https://codereview.chromium.org/2138833002/diff/1/xfa/fxfa/parser/cxfa_simple...
xfa/fxfa/parser/cxfa_simple_parser.cpp:37:
pXMLFakeRoot->GetNodeItem(CFDE_XMLNode::FirstChild);
On 2016/07/11 17:53:38, Wei Li wrote:
> Nit: no need for |pXMLFakeRoot|

Done.

[dsinclair, 2016-07-11 18:55:05]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-07-11 18:55:05]

The patchset sent to the CQ was uploaded after l-g-t-m from weili@chromium.org
Link to the patchset: https://codereview.chromium.org/2138833002/#ps20001
(title: "Review feedback")

[commit-bot: I haz the power, 2016-07-11 18:55:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-11 19:13:05]

Description was changed from

==========
Cleanup CXFA_SimpleParser.

This CL moves the static methods to an anonymous namespace and cleans up various
formatting issues.
==========

to

==========
Cleanup CXFA_SimpleParser.

This CL moves the static methods to an anonymous namespace and cleans up various
formatting issues.

Committed:
https://pdfium.googlesource.com/pdfium/+/ac14258c429141653f73ca5c1b64ad259ac1...
==========

[commit-bot: I haz the power, 2016-07-11 19:13:06]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/ac14258c429141653f73ca5c1b64ad259ac1...